Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin encode_value and decode_value should not be inside chip-tool-darwin #16080

Closed
bzbarsky-apple opened this issue Mar 10, 2022 · 1 comment · Fixed by #16417
Closed

Darwin encode_value and decode_value should not be inside chip-tool-darwin #16080

bzbarsky-apple opened this issue Mar 10, 2022 · 1 comment · Fixed by #16417
Labels
darwin

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We have codegen bits the core framework relies on that got moved into chip-tool-darwin, so now the .

Proposed Solution

The dependency should be the other way: chip-tool-darwin can depend on the framework, but not vice versa.
@bzbarsky-apple
Copy link
Contributor Author

@vivien-apple @krypton36

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Mar 18, 2022
@bzbarsky-apple
Move encode_value and decode_value back into the Darwin framework.
5925287 
chip-tool-darwin depending on the framework is fine, but the framework
depending on chip-tool-darwin is not really OK.

Fixes project-chip#16080
@bzbarsky-apple bzbarsky-apple mentioned this issue Mar 18, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Mar 18, 2022
@bzbarsky-apple
Move encode_value and decode_value back into the Darwin framework.
f768eb3 
chip-tool-darwin depending on the framework is fine, but the framework
depending on chip-tool-darwin is not really OK.

Fixes project-chip#16080
andy31415 pushed a commit that referenced this issue Mar 21, 2022
@bzbarsky-apple
Move encode_value and decode_value back into the Darwin framework. (#…
95bcd02 
…16417)

chip-tool-darwin depending on the framework is fine, but the framework
depending on chip-tool-darwin is not really OK.

Fixes #16080
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Move encode_value and decode_value back into the Darwin framework. (p…
2d62976 
…roject-chip#16417)

chip-tool-darwin depending on the framework is fine, but the framework
depending on chip-tool-darwin is not really OK.

Fixes project-chip#16080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move encode_value and decode_value back into the Darwin framework. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple