Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIP implementation of Weave Message Format #159

Closed
bhaskar-apple opened this issue Mar 31, 2020 · 5 comments
Closed

CHIP implementation of Weave Message Format #159

bhaskar-apple opened this issue Mar 31, 2020 · 5 comments
Assignees
@andy31415
Labels
feature work
Milestone
June 12, 2020

Comments

@bhaskar-apple
Copy link
Contributor

Problem

CHIP should use Weave Message Format for message framing
@bhaskar-apple bhaskar-apple self-assigned this Mar 31, 2020
@bhaskar-apple bhaskar-apple added this to the M4 milestone Mar 31, 2020
@woody-apple woody-apple changed the title CHIP should use Weave Message Format CHIP implementation of Weave Message Format Mar 31, 2020
@rwalker-apple rwalker-apple modified the milestones: May 1, 2020, May 8, 2020 May 4, 2020
@rwalker-apple
Copy link
Contributor

@andy31415 I've pushed this by a week, but don't know if this is a reasonable expectation for this work. Please adjust the milestone if necessary.

@rwalker-apple
Copy link
Contributor

@andy31415 please review milestone

@andy31415
Copy link
Contributor

I have now better familiarity with the weave code in terms of porting. It seems that the coupling and security assumptions are quite integrated within weave and I am stripping out these dependencies and trying to get smaller pull requests.

While this seems good for code review and maintainability, it is a slow process. At this point I believe that the milestone has to be pushed up significantly. I would say 29 May is much more realistic.

@andy31415
Copy link
Contributor

I also expect that we will need further steps to unify the codebase. May 29 would be an estimate to have a decoupled port (no security bits, stand-alone) of Weave Message Layer, however there need to be additional steps to integrate back security and data model.

@andy31415 andy31415 modified the milestones: May 15, 2020, May 29, 2020 May 12, 2020
@andy31415 andy31415 mentioned this issue Jun 9, 2020
Merged
@andy31415
Copy link
Contributor

Closing - transport layer diverged from WML and the message format is now based on spec rather than weave (similar, but not identical)

jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue Oct 13, 2022
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#161: Cherry-Pick Add Github Issue Automatio…
b45c731 
…n to SMG

Merge in WMN_TOOLS/matter from cherry-pick/github_automation to silabs_1.0

Squashed commit of the following:

commit 0a889751c88f167df8eb739fef475ebc18dfd267
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 14:48:35 2022 +0000

    Pull request project-chip#159: Add Github Issue Automation to SMG

    Merge in WMN_TOOLS/matter from feature/github_automation to silabs

    Squashed commit of the following:

    commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
    Author: Mathieu Kardous <[email protected]>
    Date:   Thu Oct 6 12:02:16 2022 -0400

        Update smg version field

    commit 4419dbd1181324a0f48df30175c23aff80e75682
    Author: mkardous-silabs <[email protected]>
    Date:   Tue Sep 13 09:48:58 2022 -0400

        Adding Silabs Custom Actions

        Fix issue closer
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this issue Oct 19, 2022
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#161: Cherry-Pick Add Github Issue Automatio…
da93952 
…n to SMG

Merge in WMN_TOOLS/matter from cherry-pick/github_automation to silabs_1.0

Squashed commit of the following:

commit 0a889751c88f167df8eb739fef475ebc18dfd267
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 14:48:35 2022 +0000

    Pull request project-chip#159: Add Github Issue Automation to SMG

    Merge in WMN_TOOLS/matter from feature/github_automation to silabs

    Squashed commit of the following:

    commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
    Author: Mathieu Kardous <[email protected]>
    Date:   Thu Oct 6 12:02:16 2022 -0400

        Update smg version field

    commit 4419dbd1181324a0f48df30175c23aff80e75682
    Author: mkardous-silabs <[email protected]>
    Date:   Tue Sep 13 09:48:58 2022 -0400

        Adding Silabs Custom Actions

        Fix issue closer
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Oct 24, 2022
@mkardous-silabs @jmartinez-silabs
Pull request #159: Add Github Issue Automation to SMG
3f70347 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Nov 2, 2022
@mkardous-silabs @jmartinez-silabs
Pull request #161: Cherry-Pick Add Github Issue Automation to SMG
4bd5578 
Merge in WMN_TOOLS/matter from cherry-pick/github_automation to silabs_1.0

Squashed commit of the following:

commit 0a889751c88f167df8eb739fef475ebc18dfd267
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 14:48:35 2022 +0000

    Pull request #159: Add Github Issue Automation to SMG

    Merge in WMN_TOOLS/matter from feature/github_automation to silabs

    Squashed commit of the following:

    commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
    Author: Mathieu Kardous <[email protected]>
    Date:   Thu Oct 6 12:02:16 2022 -0400

        Update smg version field

    commit 4419dbd1181324a0f48df30175c23aff80e75682
    Author: mkardous-silabs <[email protected]>
    Date:   Tue Sep 13 09:48:58 2022 -0400

        Adding Silabs Custom Actions

        Fix issue closer
rerasool pushed a commit to SiliconLabs/matter that referenced this issue Nov 2, 2022
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#161: Cherry-Pick Add Github Issue Automatio…
264b607 
…n to SMG

Merge in WMN_TOOLS/matter from cherry-pick/github_automation to silabs_1.0

Squashed commit of the following:

commit 0a889751c88f167df8eb739fef475ebc18dfd267
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 14:48:35 2022 +0000

    Pull request project-chip#159: Add Github Issue Automation to SMG

    Merge in WMN_TOOLS/matter from feature/github_automation to silabs

    Squashed commit of the following:

    commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
    Author: Mathieu Kardous <[email protected]>
    Date:   Thu Oct 6 12:02:16 2022 -0400

        Update smg version field

    commit 4419dbd1181324a0f48df30175c23aff80e75682
    Author: mkardous-silabs <[email protected]>
    Date:   Tue Sep 13 09:48:58 2022 -0400

        Adding Silabs Custom Actions

        Fix issue closer
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Dec 14, 2022
@mkardous-silabs
Pull request #159: Add Github Issue Automation to SMG
e66a5b4 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue Feb 24, 2023
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
063db50 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip May 2, 2023
@mkardous-silabs @jmartinez-silabs
Pull request #159: Add Github Issue Automation to SMG
31c1d89 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue May 18, 2023
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
e840011 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
rerasool pushed a commit to SiliconLabs/matter that referenced this issue Jun 23, 2023
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
d591cd5 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue Sep 1, 2023
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
336a982 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Oct 5, 2023
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
4ef29ab 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue Oct 25, 2023
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
296974a 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Jan 11, 2024
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
225d868 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue Jan 18, 2024
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
f9768b8 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue Feb 15, 2024
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
ca8d3ed 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue May 8, 2024
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
05c55a9 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this issue Jun 20, 2024
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
061fb15 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this issue Jun 20, 2024
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
f2bd271 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this issue Jul 18, 2024
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#159: Add Github Issue Automation to SMG
223aaee 
Merge in WMN_TOOLS/matter from feature/github_automation to silabs

Squashed commit of the following:

commit d1a2cd0d0780e925a3451ca437e1224f66a53bf2
Author: Mathieu Kardous <[email protected]>
Date:   Thu Oct 6 12:02:16 2022 -0400

    Update smg version field

commit 4419dbd1181324a0f48df30175c23aff80e75682
Author: mkardous-silabs <[email protected]>
Date:   Tue Sep 13 09:48:58 2022 -0400

    Adding Silabs Custom Actions

    Fix issue closer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy31415 andy31415

Labels
feature work
Projects
None yet
Milestone
June 12, 2020
Development

No branches or pull requests
4 participants
@andy31415 @woody-apple @bhaskar-apple @rwalker-apple