Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell] Improve memory handling of device config commands #1586

Closed
turon opened this issue Jul 13, 2020 · 0 comments · Fixed by #1574
Closed

[shell] Improve memory handling of device config commands #1586

turon opened this issue Jul 13, 2020 · 0 comments · Fixed by #1574

Comments

@turon
Copy link
Contributor

turon commented Jul 13, 2020

Problem

The example/shell application uses large stack buffers to read the contents of some configuration parameters such as device certificates.

Proposed Solution

Recast this code to use the API to determine the size of the certificates and the use MemoryAlloc to create a temporary buffer as done in OpenWeave: https://github.com/openweave/openweave-core/blob/master/src/adaptations/device-layer/CASEAuth.cpp#L114
turon added a commit to turon/connectedhomeip that referenced this issue Jul 13, 2020
@turon
[shell] PR comment resolution. Add TODO(project-chip#1586) to stack l…
38e7736 
…arge bufs.
turon added a commit to turon/connectedhomeip that referenced this issue Jul 14, 2020
@turon
[shell] Fix project-chip#1586.
d3945db
@turon turon mentioned this issue Jul 14, 2020
Merged
woody-apple pushed a commit that referenced this issue Jul 14, 2020
@turon
[shell] Add device layer commands: start, get, config. (#1574)
c10d357 
* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(#1586) to stack large bufs.

* [shell] Fix #1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this issue Jul 19, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
9efea0b 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this issue Jul 19, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
ad05005 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this issue Jul 19, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
06e78b4 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this issue Jul 21, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
1a73439 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this issue Jul 21, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
5861fce 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[shell] Add device layer commands: start, get, config. turon/connectedhomeip
1 participant
@turon