Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tizen network commissionning driver passing non-null-terminated things as char * #15777

Closed
bzbarsky-apple opened this issue Mar 3, 2022 · 1 comment · Fixed by #19157
Closed

Tizen network commissionning driver passing non-null-terminated things as char * #15777

bzbarsky-apple opened this issue Mar 3, 2022 · 1 comment · Fixed by #19157
Labels
platform security V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

See #15765 (review)

Proposed Solution

Stop doing that.

@wootak-jung
@bzbarsky-apple
Copy link
Contributor Author

Still happening, in TizenWiFiDriver::NetworkMatch.

arkq added a commit to arkq/connectedhomeip that referenced this issue Jun 3, 2022
@arkq
Use "%.*s" specifier when logging non-string data
0f065c3 
Fixes project-chip#15777
@arkq arkq mentioned this issue Jun 3, 2022
Merged
woody-apple pushed a commit that referenced this issue Jun 3, 2022
@arkq
[Tizen] Fix memory out-of-bound reads when logging (#19157)
b43b66d 
* Add more feature check to Tizen app manifest

* Use C++ casting instead of strongest C casting

* Do not log hex data byte by byte - use ChipLogByteSpan

* Use dedicated type for GATT type instead of int

* Do not return NULL in "to-string" functions

* Use "%.*s" specifier when logging non-string data

Fixes #15777

* Small cleanups in Tizen DNSsd logging

* Use sizeof(dest) when using strlcpy function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform security V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tizen] Fix memory out-of-bound reads when logging arkq/connectedhomeip
1 participant
@bzbarsky-apple