Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mWriteResponseBuilder in WriteHandler to stack #14943

Closed
erjiaqing opened this issue Feb 9, 2022 · 1 comment · Fixed by #15068
Closed

Move mWriteResponseBuilder in WriteHandler to stack #14943

erjiaqing opened this issue Feb 9, 2022 · 1 comment · Fixed by #15068
Assignees
@erjiaqing

Comments

@erjiaqing
Copy link
Contributor

As a followup (please do not try to address this in this PR): is there a reason mMessageWriter and mWriteResponseBuilder need to be persistent members of this object? Shouldn't they just have stack lifetime here?

Originally posted by @bzbarsky-apple in #13641 (comment)
@erjiaqing erjiaqing self-assigned this Feb 9, 2022
@erjiaqing erjiaqing mentioned this issue Feb 9, 2022
Merged
@bzbarsky-apple
Copy link
Contributor

OK, mWriteResponseBuilder is used in a bunch of methods called from various places outside this class, so having it be a member makes some sense. But mMessageWriter I am pretty sure we can move.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 11, 2022
@bzbarsky-apple
Remove mMessageWriter member of WriteHandler.
f7ff35c 
Fixes project-chip#14943
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 11, 2022
Merged
andy31415 pushed a commit that referenced this issue Feb 14, 2022
@bzbarsky-apple
Remove mMessageWriter member of WriteHandler. (#15068)
129841e 
Fixes #14943
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this issue Apr 26, 2022
@bzbarsky-apple @fuxingguo16
Remove mMessageWriter member of WriteHandler. (project-chip#15068)
608e3c7 
Fixes project-chip#14943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erjiaqing erjiaqing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove mMessageWriter member of WriteHandler. bzbarsky-apple/connectedhomeip
2 participants
@erjiaqing @bzbarsky-apple