Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door-Lock-Server returning Next Available Index on GetUserCommand and GetCredentialStatusCommand instead of next Occupied Index #14919

Closed
jrhees-cae opened this issue Feb 8, 2022 · 1 comment · Fixed by #18812
Closed

Door-Lock-Server returning Next Available Index on GetUserCommand and GetCredentialStatusCommand instead of next Occupied Index #14919

jrhees-cae opened this issue Feb 8, 2022 · 1 comment · Fixed by #18812
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0

Comments

@jrhees-cae
Copy link
Contributor

Problem

Door-Lock-Server.cpp is returning the Next Available user index on Get User command
Door-Lock-Server.cpp is returning the Next Available credential index on Get Credential Status command

per spec, the NextIndex for both of these commands should instead return the next occupied index.
@bzbarsky-apple bzbarsky-apple added V1.0 spec Mismatch between spec and implementation labels May 21, 2022
@bzbarsky-apple
Copy link
Contributor

Also, this code is not setting the value to null if there is no such index.

This looks like a must-fix 1.0 issue.

@Morozov-5F

@bzbarsky-apple bzbarsky-apple added the app-clusters Application cluster work label May 21, 2022
Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue May 25, 2022
@Morozov-5F
[project-chip#14919] Return the next occupied slot for GetUser/GetCre…
60c42b1 
…dentialStatus commands
@Morozov-5F Morozov-5F mentioned this issue May 25, 2022
Merged
Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue May 26, 2022
@Morozov-5F
[project-chip#14919] Return the next occupied slot for GetUser/GetCre…
2149cca 
…dentialStatus commands
Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue Jun 2, 2022
@Morozov-5F
[project-chip#14919] Return the next occupied slot for GetUser/GetCre…
e6ae3ab 
…dentialStatus commands
Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue Jun 2, 2022
@Morozov-5F
[project-chip#14919] Return the next occupied slot for GetUser/GetCre…
199e648 
…dentialStatus commands
bzbarsky-apple added a commit that referenced this issue Jun 3, 2022
@Morozov-5F @bzbarsky-apple
Handle fabric removal in the Door Lock Cluster and fix GetUser/GetCre…
9639218 
…dentialStatus commands (#18812)

* Set up the fabric removal handler in the door lock cluster

* Clear up the fabric index on fabric removal in the users and credentials of the door lock

* Add modification/creation source in the user/credential structure of the door lock

* [#14919] Return the next occupied slot for GetUser/GetCredentialStatus commands

* Apply suggestions from code review

Fix typos

Co-authored-by: Boris Zbarsky <[email protected]>

* Fix code review notes

* Update efr32 lock app and address code review feedback

* Update auto-generated files

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
2 participants
@jrhees-cae @bzbarsky-apple