Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up access control cluster/module initialization #14443

Closed
mlepage-google opened this issue Jan 27, 2022 · 2 comments · Fixed by #17357
Closed

Clean up access control cluster/module initialization #14443

mlepage-google opened this issue Jan 27, 2022 · 2 comments · Fixed by #17357
Assignees
@mlepage-google
Labels
acl Access Control feature V1.0

Comments

@mlepage-google
Copy link
Contributor

mlepage-google commented Jan 27, 2022 •
edited
Loading

In the cluster initialization, make it responsible for initializing the system module, populating the data (from flash storage), reporting unrecoverable errors to system startup, etc.

This probably needs to (or at least should) be done before #13867.
@mlepage-google mlepage-google added acl Access Control feature V1.0 labels Jan 27, 2022
@andy31415 andy31415 added v1_triage_split_2 V1.0 acl Access Control feature and removed V1.0 acl Access Control feature labels Jan 30, 2022
@mlepage-google mlepage-google self-assigned this Jan 31, 2022
@mlepage-google
Copy link
Contributor Author

This has been partially done by moving access control initialization to Server.cpp (#14680)

@mlepage-google mlepage-google mentioned this issue Apr 20, 2022
Merged
@mlepage-google
Copy link
Contributor Author

This is done by PR #17357 but let's keep this issue open to cover a few more improvements to server initialization:

  • make AclStorage an interface
  • provide it to Server::Init using initParams
  • move use of fabric table out of AclStorage::Init to keep that dependency in Server only

@mlepage-google mlepage-google mentioned this issue Apr 29, 2022
Closed
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue May 2, 2022
@mlepage-google
AclStorage dependency injection
165605c 
Make it into an inteface and inject it into Server via initParams.

Fixes project-chip#14443
@mlepage-google mlepage-google mentioned this issue May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlepage-google mlepage-google

Labels
acl Access Control feature V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor ACL persistent storage and events mlepage-google/connectedhomeip
3 participants
@andy31415 @mrjerryjohns @mlepage-google