Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failing in Darwin #14364

Closed
woody-apple opened this issue Jan 26, 2022 · 1 comment · Fixed by #14368
Closed

Test failing in Darwin #14364

woody-apple opened this issue Jan 26, 2022 · 1 comment · Fixed by #14368
Labels
build issue darwin V1.0

Comments

@woody-apple
Copy link
Contributor

Problem

https://github.com/project-chip/connectedhomeip/runs/4956221789?check_suite_focus=true

2022-01-26T19:53:24.8845590Z Failing tests:
2022-01-26T19:53:24.8845750Z 
2022-01-26T19:53:24.8845960Z 	CHIPTests:
2022-01-26T19:53:24.8847010Z 		-[CHIPClustersTests testSendClusterTest_TC_LVL_5_1_000003_WaitForMs]
2022-01-26T19:53:24.8847390Z Test session results, code coverage, and logs:
2022-01-26T19:53:24.8848000Z 	/Users/runner/Library/Developer/Xcode/DerivedData/CHIP-dhyjrdlylemwdfesoclvgithlmec/Logs/Test/Test-CHIP Framework Tests-2022.01.26_19-46-05-+0000.xcresult
2022-01-26T19:53:24.8848290Z 
2022-01-26T19:53:24.8848400Z

Proposed Solution

Fix It
@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jan 26, 2022 •
edited
Loading

Surprised this ever works! This test does:

    - label: "Wait 3000ms"
      cluster: "DelayCommands"
      command: "WaitForMs"
      arguments:
          values:
              - name: "ms"
                value: 3000

but the Darwin yaml tests have a per-step 3s timeout. See also #14260

The log has:

2022-01-26T19:52:32.3854190Z �[0;32m[1643226745286] [15142:92899] CHIP: [ZCL] (/Users/runner/work/connectedhomeip/connectedhomeip/src/darwin/Framework/CHIPTests/CHIPClustersTests.m:12555: error: -[CHIPClustersTests testSendClusterTest_TC_LVL_5_1_000003_WaitForMs] : Asynchronous wait failed: Exceeded timeout of 3 seconds, with unfulfilled expectations: "Wait 3000ms".
2022-01-26T19:52:32.3914850Z Test Case '-[CHIPClustersTests testSendClusterTest_TC_LVL_5_1_000003_WaitForMs]' failed (8.122 seconds).

Will fix together with #14260.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 26, 2022
@bzbarsky-apple
Make the Darwin per-step YAML timeouts larger and configurable.
4834ca4 
This makes the following changes:

1) Bumps kTimeoutInSeconds from 3 to 5.
2) For "WaitForMs" commands, sets the timeout to
   (waitTime/1000) + kTimeoutInSeconds, so longish waits work automatically.
3) Allows specifying a "stepTimeoutSecs" property in the YAML to override
   all of that and just set a value.

Fixes project-chip#14364
Fixes project-chip#14260
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 26, 2022
Merged
woody-apple pushed a commit that referenced this issue Jan 27, 2022
@bzbarsky-apple
Make the Darwin per-step YAML timeouts larger and configurable. (#14368)
a255464 
This makes the following changes:

1) Bumps kTimeoutInSeconds from 3 to 5.
2) For "WaitForMs" commands, sets the timeout to
   (waitTime/1000) + kTimeoutInSeconds, so longish waits work automatically.
3) Allows specifying a "stepTimeoutSecs" property in the YAML to override
   all of that and just set a value.

Fixes #14364
Fixes #14260
selissia pushed a commit to selissia/connectedhomeip that referenced this issue Jan 28, 2022
@bzbarsky-apple @selissia
Make the Darwin per-step YAML timeouts larger and configurable. (proj…
1dd4e77 
…ect-chip#14368)

This makes the following changes:

1) Bumps kTimeoutInSeconds from 3 to 5.
2) For "WaitForMs" commands, sets the timeout to
   (waitTime/1000) + kTimeoutInSeconds, so longish waits work automatically.
3) Allows specifying a "stepTimeoutSecs" property in the YAML to override
   all of that and just set a value.

Fixes project-chip#14364
Fixes project-chip#14260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build issue darwin V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the Darwin per-step YAML timeouts larger and configurable. bzbarsky-apple/connectedhomeip
2 participants
@woody-apple @bzbarsky-apple