Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Endpoints to INT16U array in Bridged Action Clusters XML #14074

Closed
woody-apple opened this issue Jan 25, 2022 · 3 comments · Fixed by #18622
Closed

Change Endpoints to INT16U array in Bridged Action Clusters XML #14074

woody-apple opened this issue Jan 25, 2022 · 3 comments · Fixed by #18622
Assignees
@pjzander-signify
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation todo 🗒️ V1.0

Comments

@woody-apple
Copy link
Contributor

false

connectedhomeip/src/app/zap-templates/zcl/data-model/chip/bridged-actions-cluster.xml

Lines 83 to 88 in f0f5de0

<!-- TODO: Change Endpoints to INT16U array once it is supported -->
<item name="Endpoints" type="ENDPOINT_NO" array="true" length="256"/>
</struct>
<cluster>
<domain>General</domain>

This issue was generated by todo-issue based on a TODO comment in f0f5de0.
@tcarmelveilleux tcarmelveilleux changed the title Change Endpoints to INT16U array once it is supported Change Endpoints to INT16U array in Bridged Action Clusters XML Jan 31, 2022
@tcarmelveilleux tcarmelveilleux added spec Mismatch between spec and implementation and removed v1_triage_split_3 labels Jan 31, 2022
@bzbarsky-apple bzbarsky-apple added the app-clusters Application cluster work label May 5, 2022
@bzbarsky-apple
Copy link
Contributor

Struct members that are lists are very much supported and have been for quite a while.

@bzbarsky-apple
Copy link
Contributor

@pjzander-signify Are you blocked on something here?

@bzbarsky-apple bzbarsky-apple mentioned this issue May 5, 2022
Closed
@bzbarsky-apple
Copy link
Contributor

Oh, this got fixed in #12065. We just forgot to remove the TODO comment.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 19, 2022
@bzbarsky-apple
Remove out-of-date TODO comment.
025d124 
The change the comment wants happened in project-chip#12065

Fixes project-chip#14074
@bzbarsky-apple bzbarsky-apple mentioned this issue May 19, 2022
Merged
andy31415 pushed a commit that referenced this issue May 19, 2022
@bzbarsky-apple
Remove out-of-date TODO comment. (#18622)
d222519 
The change the comment wants happened in #12065

Fixes #14074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjzander-signify pjzander-signify

Labels
app-clusters Application cluster work spec Mismatch between spec and implementation todo 🗒️ V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove out-of-date TODO comment. bzbarsky-apple/connectedhomeip
5 participants
@tcarmelveilleux @andy31415 @woody-apple @bzbarsky-apple @pjzander-signify