Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenThread Dependencies for EFR32 #139

Closed
sagar-apple opened this issue Mar 26, 2020 · 2 comments
Closed

Fix OpenThread Dependencies for EFR32 #139

sagar-apple opened this issue Mar 26, 2020 · 2 comments
Milestone

Comments

@sagar-apple
Copy link
Contributor

sagar-apple commented Mar 26, 2020

Problem

#125 Removed OpenThread dependencies from efr32-chip.mk and in the platform code.
It also removed dependencies on missing SEGGER header files(ref: src/platform/EFR32/Logging.cpp) and so if a project adds EFR32_LOG_ENABLED to their CHIPProjectConfig.h the build will not work.

The missing SEGGER headers, for example, are part of OpenThread.

Proposed Solution

Figure out if OpenTread is a hard dependency for all EFR32 apps (followed the openweave demo example) and if not bring in the missing SEGGER dependencies and make sure EFR32_LOG_ENABLED can be set.

@sagar-apple sagar-apple added this to the M4 milestone Mar 26, 2020
@sagar-apple sagar-apple changed the title Fix SEGGER dependencies in EFR32 Logging Fix OpenThread Dependencies for EFR32 Mar 26, 2020
@rwalker-apple
Copy link
Contributor

@sagar-apple can you please re-assess and assign a reasonable milestone or close?

@sagar-apple
Copy link
Contributor Author

We have not yet taken a decision on the usage of OT. Closing this as it's an implicit part of making the EFR32 feature complete.

gvargas-csa added a commit to gvargas-csa/connectedhomeip that referenced this issue Feb 14, 2024
TC-APPLAUNCHER-3.7.1, TC-APPLAUNCHER-3.8.1 and TCAPPLAUNCHER-3.9.1
was updated as per verification step document (DUT as Client) issue project-chip#139
mergify bot pushed a commit that referenced this issue Feb 16, 2024
* chore(TC-DESC-2.1): modified step 1b comments as per verification step document

* chore(TL-LTIME-3.1): updated step 9 command and log as verification step

modifications as per verfication step document issue #122

* chore(TC-CNET-4.22): modifications for steps 1, 3, 5

modifications in logs for step 1, 3, 5 as verification step document
changes issue #125

* chore(TC-DRLK-2.1): modification for step 13a PICS

modification for step 13a (From DRLK.S.F0b && DRLK.S.A0015 to
DRLK.S.F0b && DRLK.S.A0016) as per test plan changes issue #128

* chore(TC-LCFG-2.1):modifications for PICS step 1a,3

In step 1a and 3 supportedLocales attribute PICS has to be updated
LCFG.S.A0001 instead LCFG.S.A0000 as per test plan issue #129

* chore(TC-APPLAUNCHER-3.x.1): modify commands

TC-APPLAUNCHER-3.7.1, TC-APPLAUNCHER-3.8.1 and TCAPPLAUNCHER-3.9.1
was updated as per verification step document (DUT as Client) issue #139

* Updates Test_TC_LWM_1_1.yaml

* Updates Test_TC_TCCM_1_1.yaml

* Updates Test_TC_LWM_1_1.yaml

* Updates  Test_TC_DISHM_1_1.yaml

* Updates Test_TC_DISHM_3_1.yaml

* Updates Test_TC_DISHM_3_3.yaml

* chore(TC-CONTENTLAUNCHER-10.4): update command and logs

command and logs has been updated as per verification step document
for all steps

* chore(TC-CONTENTLAUNCHER-10.6):update command

command has been updated as per verification step document

* Updates Test_TC_ICDM_3_4.yaml

* chore(TC-ALOGIN-12.2): update command in precondition

command has been updated in precondition as per verification
step document

* Updates Test_TC_CNET_4_9.yaml

* Updates Test_TC_CNET_4_10.yaml

* Updates Test_TC_CNET_4_11.yaml

* Adds NetworkIndex to response in CNET TCs (4.9, 4.10, 4.11)

* Updates Test_TC_TCCM_3_1.yaml

* Updates Test_TC_TCCM_3_3.yaml

* Updates Test_TC_LWM_3_1.yaml

* Updates Test_TC_LWM_3_3.yaml

* Updates Test_TC_OTCCM_1_1.yaml

* Updates Test_TC_OTCCM_2_1.yaml

* Updates Test_TC_S_3_1.yaml

* Restores TC-LWM-1.1

* Restores TC-TCCM-1.1

* Fix yaml formatting

* Fix restyle

* Fix restyle

* Fix restyle

* Removes (DEPONOFF) from pics ref

---------

Co-authored-by: raul-marquez-csa <[email protected]>
Co-authored-by: Raul Marquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants