Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more generated code in Access Control cluster #13470

Closed
mlepage-google opened this issue Jan 11, 2022 · 2 comments
Closed

Use more generated code in Access Control cluster #13470

mlepage-google opened this issue Jan 11, 2022 · 2 comments
Assignees
Labels
acl Access Control feature V1.X

Comments

@mlepage-google
Copy link
Contributor

mlepage-google commented Jan 11, 2022

Don't duplicate encode/decode code for access control cluster, instead reuse the generated code.

This will result in less maintenance fragility.

Challenge is to also make it work for persistence (load/save from flash storage). This means it needs to fabric filter in the cluster read/write/etc. case, but not in the storage load/save case.

Cluster code is in access-control-server.cpp
Generated encode/decode code is in cluster-objects.cpp (and .h).
Other encode/decode code is in Encode.h and Decode.h.

@mlepage-google
Copy link
Contributor Author

@harimau-qirex This relates to #10251

mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Jan 12, 2022
Re-use more of the generated code (Encode/Decode) from
cluster-objects.cpp (and .h).

Progress toward issue project-chip#13470
mlepage-google added a commit that referenced this issue Jan 13, 2022
Re-use more of the generated code (Encode/Decode) from
cluster-objects.cpp (and .h).

Progress toward issue #13470
@mlepage-google mlepage-google added the acl Access Control feature label Jan 27, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this issue Jan 28, 2022
Re-use more of the generated code (Encode/Decode) from
cluster-objects.cpp (and .h).

Progress toward issue project-chip#13470
@mlepage-google mlepage-google self-assigned this Jan 31, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this issue Feb 8, 2022
Re-use more of the generated code (Encode/Decode) from
cluster-objects.cpp (and .h).

Progress toward issue project-chip#13470
@mlepage-google
Copy link
Contributor Author

This is encompassed by #14451, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acl Access Control feature V1.X
Projects
None yet
Development

No branches or pull requests

2 participants