Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS unused #12939

Closed
kpschoedel opened this issue Dec 13, 2021 · 0 comments · Fixed by #13188
Closed

INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS unused #12939

kpschoedel opened this issue Dec 13, 2021 · 0 comments · Fixed by #13188
Assignees
@kpschoedel

Comments

@kpschoedel
Copy link
Contributor

Problem

The option INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS is not enabled by any configuration in tree, and clutters up TCP code.

Proposed Solution

Remove the option.
@kpschoedel kpschoedel self-assigned this Dec 13, 2021
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 21, 2021
@kpschoedel
Remove INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS
f626ef8 
#### Problem

The option `INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS` is not
enabled by any configuration in tree, and clutters up TCP code.

Fixes project-chip#12939 INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS unused

#### Change overview

- Remove `INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS` and associated code

#### Testing

CI/build. No functional change since the option is unused.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 21, 2021
@kpschoedel
Remove INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS
b1b9e5c 
#### Problem

The option `INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS` is not
enabled by any configuration in tree, and clutters up TCP code.

Fixes project-chip#12939 INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS unused

#### Change overview

- Remove `INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS` and associated code

#### Testing

CI/build. No functional change since the option is unused.
@kpschoedel kpschoedel mentioned this issue Dec 21, 2021
Merged
bzbarsky-apple pushed a commit that referenced this issue Dec 22, 2021
@kpschoedel
Remove INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS (#13188)
92b9ef8 
#### Problem

The option `INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS` is not
enabled by any configuration in tree, and clutters up TCP code.

Fixes #12939 INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS unused

#### Change overview

- Remove `INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS` and associated code

#### Testing

CI/build. No functional change since the option is unused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpschoedel kpschoedel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove INET_CONFIG_ENABLE_TCP_SEND_IDLE_CALLBACKS kpschoedel/connectedhomeip
1 participant
@kpschoedel