Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Impl's underlying ObjectPool statistics #12378

Closed
todo bot opened this issue Nov 30, 2021 · 0 comments · Fixed by #12885
Closed

Use the Impl's underlying ObjectPool statistics #12378

todo bot opened this issue Nov 30, 2021 · 0 comments · Fixed by #12885
Assignees
@kpschoedel
Labels
todo

Comments

@todo
Copy link

todo bot commented Nov 30, 2021

connectedhomeip/src/inet/InetLayer.h

Lines 79 to 89 in 5dd2f93

// TODO: Use the Impl's underlying ObjectPool statistics
SYSTEM_STATS_INCREMENT(EndPointProperties<EndPointType>::SystemStatsKey);
return CHIP_NO_ERROR;
}
virtual EndPoint * CreateEndPoint() = 0;
virtual void DeleteEndPoint(EndPoint * endPoint) = 0;
virtual bool ForEachEndPoint(const EndPointVisitor visitor) = 0;
private:
System::Layer * mSystemLayer;

This issue was generated by todo based on a TODO comment in 5dd2f93 when #12291 was merged. cc @kpschoedel.
@todo todo bot added the todo label Nov 30, 2021
@kpschoedel kpschoedel mentioned this issue Dec 7, 2021
Closed
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 9, 2021
@kpschoedel
[Inet] Test EndPoint statistics
855f51e 
#### Problem

Fixes project-chip#12378 Use the Impl's underlying ObjectPool statistics

#### Change overview

Decided to fix the existing method, with a deletion wrapper.

Added stats macros for unit testing.

#### Testing

Added unit test assertions.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 9, 2021
@kpschoedel
[Inet] Test EndPoint statistics
a9bb9ea 
#### Problem

Fixes project-chip#12378 Use the Impl's underlying ObjectPool statistics

#### Change overview

Decided to fix the existing method, with a deletion wrapper.

Added stats macros for unit testing.

#### Testing

Added unit test assertions.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 10, 2021
@kpschoedel
[Inet] Test EndPoint statistics
82e299a 
#### Problem

Fixes project-chip#12378 Use the Impl's underlying ObjectPool statistics

#### Change overview

Decided to fix the existing method, with a deletion wrapper.

Added stats macros for unit testing.

#### Testing

Added unit test assertions.
@kpschoedel kpschoedel mentioned this issue Dec 10, 2021
Merged
andy31415 pushed a commit that referenced this issue Dec 10, 2021
@kpschoedel
[Inet] Test EndPoint statistics (#12885)
4c5d042 
#### Problem

Fixes #12378 Use the Impl's underlying ObjectPool statistics

#### Change overview

Decided to fix the existing method, with a deletion wrapper.

Added stats macros for unit testing.

#### Testing

Added unit test assertions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpschoedel kpschoedel

Labels
todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Inet] Test EndPoint statistics kpschoedel/connectedhomeip
1 participant
@kpschoedel