Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDX messages monitoring/processing should be done by Test Harness #11552

Closed
ukatira opened this issue Nov 8, 2021 · 4 comments
Closed

BDX messages monitoring/processing should be done by Test Harness #11552

ukatira opened this issue Nov 8, 2021 · 4 comments
Labels
cert stale Stale issue or PR V1.X

Comments

@ukatira
Copy link

ukatira commented Nov 8, 2021

Problem

Currently we are logging BDX messages on OTA Reference Apps to enable testing for TE7

[1636153795565] [83609:59400960] CHIP: [BDX] Sending BDX Message
[1636153795565] [83609:59400960] CHIP: [BDX] ReceiveInit
[1636153795565] [83609:59400960] CHIP: [BDX] Proposed Transfer Control: 0x20
[1636153795565] [83609:59400960] CHIP: [BDX] Range Control: 0x0
[1636153795565] [83609:59400960] CHIP: [BDX] Proposed Max Block Size: 1024
[1636153795565] [83609:59400960] CHIP: [BDX] Start Offset: 0x0000000000000000
[1636153795565] [83609:59400960] CHIP: [BDX] Proposed Max Length: 0x0000000000000000
[1636153795565] [83609:59400960] CHIP: [BDX] File Designator Length: 8
[1636153795565] [83609:59400960] CHIP: [BDX] File Designator: test.txt

Proposed Solution

Test Harness should inspect BDX packets that come through and perform verification at that level rather than parsing logs on OTA reference apps

tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jan 19, 2022
- Tracing now works enough that it's generally useful
- Tracing is already gated by command-line args, so not
  running by default.
- This PR enables the build to always include tracing feature
  enabled in chip-tool since it's generally useful.

Testing done:

- Unit tests and integration pass with no change
- chip-tool now always has --trace_log/--trace_file enabled

Issue project-chip#11552
woody-apple pushed a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jan 19, 2022
- Tracing now works enough that it's generally useful
- Tracing is already gated by command-line args, so not
  running by default.
- This PR enables the build to always include tracing feature
  enabled in chip-tool since it's generally useful.

Testing done:

- Unit tests and integration pass with no change
- chip-tool now always has --trace_log/--trace_file enabled

Issue project-chip#11552
andy31415 pushed a commit that referenced this issue Jan 19, 2022
* Enable building tracing in chip-tool by default

- Tracing now works enough that it's generally useful
- Tracing is already gated by command-line args, so not
  running by default.
- This PR enables the build to always include tracing feature
  enabled in chip-tool since it's generally useful.

Testing done:

- Unit tests and integration pass with no change
- chip-tool now always has --trace_log/--trace_file enabled

Issue #11552

* Restyled by prettier-markdown

Co-authored-by: Restyled.io <[email protected]>
selissia pushed a commit to selissia/connectedhomeip that referenced this issue Jan 28, 2022
* Enable building tracing in chip-tool by default

- Tracing now works enough that it's generally useful
- Tracing is already gated by command-line args, so not
  running by default.
- This PR enables the build to always include tracing feature
  enabled in chip-tool since it's generally useful.

Testing done:

- Unit tests and integration pass with no change
- chip-tool now always has --trace_log/--trace_file enabled

Issue project-chip#11552

* Restyled by prettier-markdown

Co-authored-by: Restyled.io <[email protected]>
@holbrookt
Copy link
Contributor

@ukatira Is this an issue for 1.0?

@ukatira
Copy link
Author

ukatira commented Feb 1, 2022

I'm okay if we continue having these log prints in OTA Reference Apps to enable verification for 1.0

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 31, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cert stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

4 participants