Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement remaining access control for IM read #10239

Closed
mlepage-google opened this issue Oct 5, 2021 · 1 comment
Closed

Implement remaining access control for IM read #10239

mlepage-google opened this issue Oct 5, 2021 · 1 comment
Labels
acl Access Control feature V1.0

Comments

@mlepage-google
Copy link
Contributor

mlepage-google commented Oct 5, 2021 •
edited
Loading

  • initial prototype adds access control for IM read in a basic way (Initial ACL prototype implementation #10236)
  • this task is for fleshing it out fully
  • events (like attributes)
  • wildcard reads need to be implemented (dependency in IM)
  • access denials for wildcard paths need to be handled differently (discard vs. error)
  • note fabric filtering is covered in another task
  • individual list item index reading is not going to be supported in 1.0, so no need for now
@mlepage-google mlepage-google added the acl Access Control feature label Oct 5, 2021
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Jan 11, 2022
@mlepage-google
Fix and refactor ReadSingleClusterData
e7498ef 
PR project-chip#12660 seems to have refactored ReadSingleClusterData in such a way
that the access control check may be skipped. (Possibly due to merge?)

Fix this by refactoring the function to a sensible flow of checks.

Progress towards project-chip#10239
@mlepage-google mlepage-google mentioned this issue Jan 11, 2022
Merged
bzbarsky-apple added a commit that referenced this issue Jan 12, 2022
@mlepage-google @bzbarsky-apple
Fix and refactor ReadSingleClusterData (#13468)
96c6645 
* Fix and refactor ReadSingleClusterData

PR #12660 seems to have refactored ReadSingleClusterData in such a way
that the access control check may be skipped. (Possibly due to merge?)

Fix this by refactoring the function to a sensible flow of checks.

Progress towards #10239

* Apply review comment.

Co-authored-by: Boris Zbarsky <[email protected]>
@mlepage-google
Copy link
Contributor Author

Everything in the list is done now except for read events, which will be tracked in a separate issue.

selissia pushed a commit to selissia/connectedhomeip that referenced this issue Jan 28, 2022
@mlepage-google @bzbarsky-apple @selissia
Fix and refactor ReadSingleClusterData (project-chip#13468)
c1a0418 
* Fix and refactor ReadSingleClusterData

PR project-chip#12660 seems to have refactored ReadSingleClusterData in such a way
that the access control check may be skipped. (Possibly due to merge?)

Fix this by refactoring the function to a sensible flow of checks.

Progress towards project-chip#10239

* Apply review comment.

Co-authored-by: Boris Zbarsky <[email protected]>
step0035 pushed a commit to hank820/connectedhomeip that referenced this issue Feb 8, 2022
@mlepage-google @bzbarsky-apple @step0035
Fix and refactor ReadSingleClusterData (project-chip#13468)
bf7f6a9 
* Fix and refactor ReadSingleClusterData

PR project-chip#12660 seems to have refactored ReadSingleClusterData in such a way
that the access control check may be skipped. (Possibly due to merge?)

Fix this by refactoring the function to a sensible flow of checks.

Progress towards project-chip#10239

* Apply review comment.

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acl Access Control feature V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@woody-apple @mlepage-google