Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The static cast should have the / 1000 within it, rather than outside. Otherwise it's possible that it will overrun after not that long. #10144

Closed
andy31415 opened this issue Oct 1, 2021 · 0 comments · Fixed by #10153
Closed

The static cast should have the / 1000 within it, rather than outside. Otherwise it's possible that it will overrun after not that long. #10144

andy31415 opened this issue Oct 1, 2021 · 0 comments · Fixed by #10153
Assignees
@kpschoedel

Comments

@andy31415
Copy link
Contributor

The static cast should have the / 1000 within it, rather than outside. Otherwise it's possible that it will overrun after not that long.

Originally posted by @tcarmelveilleux in #10056 (comment)
@andy31415 andy31415 mentioned this issue Oct 1, 2021
Merged
@kpschoedel kpschoedel self-assigned this Oct 1, 2021
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Oct 1, 2021
@kpschoedel
System::Clock cleanup
5b60441 
#### Problem

Followups from PR project-chip#10056 Indirect access for System::Clock functions

Fixes project-chip#10146 Remove GetMonotonicMicroseconds() call
Fixes project-chip#10145 remove.
Fixes project-chip#10144 The static cast should have the / 1000 within it

#### Change overview

- Removes the global backward-compatibility wrappers for `GetMonotonic…()`.
- Correctly parenthesize the project-chip#10146 cast.

#### Testing

CI. No changes to functionality intended.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Oct 1, 2021
@kpschoedel
System::Clock cleanup
7071565 
#### Problem

Followups from PR project-chip#10056 Indirect access for System::Clock functions

Fixes project-chip#10146 Remove GetMonotonicMicroseconds() call
Fixes project-chip#10145 remove.
Fixes project-chip#10144 The static cast should have the / 1000 within it

#### Change overview

- Removes the global backward-compatibility wrappers for `GetMonotonic…()`.
- Correctly parenthesize the project-chip#10146 cast.

#### Testing

CI. No changes to functionality intended.
@kpschoedel kpschoedel mentioned this issue Oct 1, 2021
Merged
andy31415 pushed a commit that referenced this issue Oct 4, 2021
@kpschoedel
System::Clock cleanup (#10153)
4905a6b 
#### Problem

Followups from PR #10056 Indirect access for System::Clock functions

Fixes #10146 Remove GetMonotonicMicroseconds() call
Fixes #10145 remove.
Fixes #10144 The static cast should have the / 1000 within it

#### Change overview

- Removes the global backward-compatibility wrappers for `GetMonotonic…()`.
- Correctly parenthesize the #10146 cast.

#### Testing

CI. No changes to functionality intended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpschoedel kpschoedel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor System::Clock cleanup kpschoedel/connectedhomeip
2 participants
@andy31415 @kpschoedel