Skip to content

Commit

Permalink
all-clusters: Fix conformance on door-lock (#29743)
Browse files Browse the repository at this point in the history
* all-clusters: Fix conformance on door-lock

Door lock currently supports features 3, 4, 5, and 6, all of which
require the DPS feature. As all the supported pieces for this feature
are already on, I turned on the feature (bit 5)

Door lock currently support feature 0x33, which requires the COTA
feature (bit 7), so I turned this feature on.

Door lock currently has on the YDSCH and HDSCH features in the
feature map. This looks deliberate, but it requires the commands
0x10, 0x11, 0x12 (both ways) and 0x13, so I turned these commands on.

* Turn off YDSCH and HDSCH features and cmds / attrs
  • Loading branch information
cecille authored and pull[bot] committed Nov 2, 2023
1 parent c6bfccd commit fd740d8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 44 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3636,8 +3636,6 @@ server cluster DoorLock = 257 {
readonly attribute int16u numberOfPINUsersSupported = 18;
readonly attribute int16u numberOfRFIDUsersSupported = 19;
readonly attribute int8u numberOfWeekDaySchedulesSupportedPerUser = 20;
readonly attribute int8u numberOfYearDaySchedulesSupportedPerUser = 21;
readonly attribute int8u numberOfHolidaySchedulesSupported = 22;
readonly attribute int8u maxPINCodeLength = 23;
readonly attribute int8u minPINCodeLength = 24;
readonly attribute int8u maxRFIDCodeLength = 25;
Expand Down Expand Up @@ -7152,8 +7150,6 @@ endpoint 1 {
ram attribute numberOfPINUsersSupported default = 10;
ram attribute numberOfRFIDUsersSupported default = 10;
ram attribute numberOfWeekDaySchedulesSupportedPerUser default = 10;
ram attribute numberOfYearDaySchedulesSupportedPerUser default = 10;
ram attribute numberOfHolidaySchedulesSupported default = 0;
ram attribute maxPINCodeLength default = 6;
ram attribute minPINCodeLength default = 6;
ram attribute maxRFIDCodeLength default = 20;
Expand All @@ -7172,7 +7168,7 @@ endpoint 1 {
ram attribute wrongCodeEntryLimit default = 3;
ram attribute userCodeTemporaryDisableTime default = 10;
ram attribute requirePINforRemoteOperation default = 0;
ram attribute featureMap default = 0x1D13;
ram attribute featureMap default = 0x11B3;
ram attribute clusterRevision default = 6;

handle command LockDoor;
Expand Down
46 changes: 7 additions & 39 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@
}
],
"package": [
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/zcl/zcl-with-test-extensions.json",
"type": "zcl-properties",
"category": "matter",
"version": 1,
"description": "Matter SDK ZCL data with some extensions"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
}
],
"endpointTypes": [
Expand Down Expand Up @@ -11997,38 +11997,6 @@
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfYearDaySchedulesSupportedPerUser",
"code": 21,
"mfgCode": null,
"side": "server",
"type": "int8u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "10",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfHolidaySchedulesSupported",
"code": 22,
"mfgCode": null,
"side": "server",
"type": "int8u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "MaxPINCodeLength",
"code": 23,
Expand Down Expand Up @@ -12327,7 +12295,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x1D13",
"defaultValue": "0x11B3",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
Expand Down

0 comments on commit fd740d8

Please sign in to comment.