Address review comment.

project-chip · Jul 26, 2022 · f84e2d4 · f84e2d4
1 parent cd6deef
commit f84e2d4
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/lib/support/SetupDiscriminator.h b/src/lib/support/SetupDiscriminator.h
@@ -88,8 +88,6 @@ class SetupDiscriminator
     }
 
 private:
-    static_assert(kLongBits == 12, "Unexpected field length");
-
     static constexpr uint16_t kLongMask = (1 << kLongBits) - 1;
     static constexpr uint8_t kShortMask = (1 << kShortBits) - 1;
 
@@ -101,9 +99,11 @@ class SetupDiscriminator
     }
 
     // If long discriminator, all 12 bits are used.  If short discriminator,
-    // only the low kManualSetupDiscriminatorFieldLengthInBits bits are used, to
-    // store the value of the short discriminator (which contains only the high
-    // bits of the complete 12-bit discriminator).
+    // only the low kShortBits bits are used, to store the value of the short
+    // discriminator (which contains only the high bits of the complete 12-bit
+    // discriminator).
+    static_assert(kLongBits == 12, "Unexpected field length");
+    static_assert(kShortBits <= kLongBits, "Unexpected field length");
     uint16_t mDiscriminator : 12;
     uint16_t mIsShortDiscriminator : 1;
 };