fix stragglers, restyle

project-chip · Jul 26, 2022 · f158c8e · f158c8e
1 parent 2282310
commit f158c8e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/controller/AutoCommissioner.cpp b/src/controller/AutoCommissioner.cpp
@@ -545,10 +545,17 @@ void AutoCommissioner::PauseCommissioning()
 
 CHIP_ERROR AutoCommissioner::ResumeCommissioning()
 {
-    VerifyOrReturnError(mPausedStage != CommissioningStage::kError, CHIP_ERROR_INCORRECT_STATE);
+    VerifyOrReturnError(mCommissioningPaused, CHIP_ERROR_INCORRECT_STATE);
+    mCommissioningPaused = false;
+
+    // if no new step was attempted
+    if (mPausedStage == CommissioningStage::kError)
+    {
+        return CHIP_NO_ERROR;
+    }
+
     CommissioningStage nextStage = mPausedStage;
     mPausedStage                 = CommissioningStage::kError;
-    mCommissioningPaused         = false;
 
     return PerformStep(nextStage);
 }

diff --git a/src/controller/java/src/chip/devicecontroller/ControllerParams.java b/src/controller/java/src/chip/devicecontroller/ControllerParams.java
@@ -115,7 +115,7 @@ public Builder setControllerVendorId(int controllerVendorId) {
       this.controllerVendorId = controllerVendorId;
       return this;
     }
-    
+
     public Builder setFailsafeTimerSeconds(int failsafeTimerSeconds) {
       if (failsafeTimerSeconds < 1 || failsafeTimerSeconds > 900) {
         throw new IllegalArgumentException("failsafeTimerSeconds must be between 0 and 900");