Updated as per new review feedback and fixed builds

project-chip · May 31, 2024 · efb2652 · efb2652
1 parent 8b20629
commit efb2652
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/lib/dnssd/Discovery_ImplPlatform.cpp b/src/lib/dnssd/Discovery_ImplPlatform.cpp
@@ -96,15 +96,14 @@ static void HandleNodeBrowse(void * context, DnssdService * services, size_t ser
         auto & ipAddress = services[i].mAddress;
 
         // mType(service name) exactly matches with operational service name
-        bool isOperationalBrowse = (strncmp(services[i].mType, kOperationalServiceName, sizeof(services[i].mType)) == 0 &&
-                                    strlen(services[i].mType) == strlen(kOperationalServiceName));
+        bool isOperationalBrowse = strcmp(services[i].mType, kOperationalServiceName) == 0;
 
         // For operational browse result we currently don't need IP address hence skip resolution and handle differently.
         if (isOperationalBrowse)
         {
             HandleNodeOperationalBrowse(context, &services[i], error);
         }
-        // if SRV, TXT and AAAA records were received in DNS responses
+        // check whether SRV, TXT and AAAA records were received in DNS responses
         else if (strlen(services[i].mHostName) == 0 || services[i].mTextEntrySize == 0 || !ipAddress.has_value())
         {
             ChipDnssdResolve(&services[i], services[i].mInterface, HandleNodeResolve, context);

diff --git a/src/platform/Darwin/DnssdContexts.cpp b/src/platform/Darwin/DnssdContexts.cpp
@@ -609,8 +609,7 @@ bool ResolveContext::TryReportingResultsForInterfaceIndex(uint32_t interfaceInde
         DiscoveredNodeData nodeData;
 
         // mType(service name) exactly matches with operational service name
-        if (strncmp(services[i].mType, kOperationalServiceName, sizeof(services[i].mType)) == 0 &&
-            strlen(services[i].mType) == strlen(kOperationalServiceName))
+        if (strncmp(service[i].mType, kOperationalServiceName) == 0)
         {
             service.ToDiscoveredOperationalNodeBrowseData(nodeData);
         }