Skip to content

Commit

Permalink
Minor fixes.
Browse files Browse the repository at this point in the history
* remove a check that was inadvertently kept.
* print a log message when something that shouldn't happen inevitably does.
* use user_params to get the end user support log test parameter.
  • Loading branch information
harimau-qirex committed Sep 11, 2024
1 parent efebf7f commit e2726ae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/controller/python/chip/bdx/bdx-transfer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ CHIP_ERROR BdxTransfer::Reject()

void BdxTransfer::HandleTransferSessionOutput(TransferSession::OutputEvent & event)
{
assertChipStackLockedByCurrentThread();

ChipLogDetail(BDX, "Received event %s", event.ToString(event.EventType));

switch (event.EventType)
Expand Down Expand Up @@ -124,6 +122,7 @@ void BdxTransfer::HandleTransferSessionOutput(TransferSession::OutputEvent & eve
break;
default:
// Should never happen.
ChipLogError(BDX, "Unhandled BDX transfer session event type %d.", static_cast<int>(event.EventType));
chipDie();
break;
}
Expand Down
2 changes: 1 addition & 1 deletion src/python_testing/TestBdxTransfer.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ async def test_bdx_transfer(self):
data = await bdx_transfer.accept()

self.step(6)
data_file = open(self.matter_test_config.global_test_params["end_user_support_log"], "rb")
data_file = open(self.user_params["end_user_support_log"], "rb")
asserts.assert_equal(bytearray(data), data_file.read(), "Transferred data doesn't match")

self.step(7)
Expand Down

0 comments on commit e2726ae

Please sign in to comment.