Modifying the pics_ function to better vibe with Cecille's plan

project-chip · Jan 19, 2024 · dbdb6f9 · dbdb6f9
1 parent 9b05625
commit dbdb6f9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/src/python_testing/TC_FAN_3_2.py b/src/python_testing/TC_FAN_3_2.py
@@ -45,10 +45,14 @@ async def write_speed_setting(self, endpoint, speed_setting) -> Status:
         return result[0].Status
 
     def pics_TC_FAN_3_2(self) -> list[str]:
-        return ["FAN.S", "FAN.S.F00"]
+        return ["FAN.S"]
 
     @async_test_body
     async def test_TC_FAN_3_2(self):
+        if not self.check_pics("FAN.S.F00"):
+            logger.info("Test skipped because PICS FAN.S.F00 is not set")
+            return
+
         endpoint = self.user_params.get("endpoint", 1)
 
         self.print_step(1, "Commissioning, already done")

diff --git a/src/python_testing/TC_FAN_3_3.py b/src/python_testing/TC_FAN_3_3.py
@@ -43,10 +43,14 @@ async def write_rock_setting(self, endpoint, rock_setting):
         asserts.assert_equal(result[0].Status, Status.Success, "RockSetting write failed")
 
     def pics_TC_FAN_3_3(self) -> list[str]:
-        return ["FAN.S", "FAN.S.F02"]
+        return ["FAN.S"]
 
     @async_test_body
     async def test_TC_FAN_3_3(self):
+        if not self.check_pics("FAN.S.F02"):
+            logger.info("Test skipped because PICS FAN.S.F02 is not set")
+            return
+
         endpoint = self.user_params.get("endpoint", 1)
 
         self.print_step(1, "Commissioning, already done")

diff --git a/src/python_testing/TC_FAN_3_4.py b/src/python_testing/TC_FAN_3_4.py
@@ -43,10 +43,14 @@ async def write_wind_setting(self, endpoint, wind_setting):
         asserts.assert_equal(result[0].Status, Status.Success, "WindSetting write failed")
 
     def pics_TC_FAN_3_4(self) -> list[str]:
-        return ["FAN.S", "FAN.S.F03"]
+        return ["FAN.S"]
 
     @async_test_body
     async def test_TC_FAN_3_4(self):
+        if not self.check_pics("FAN.S.F03"):
+            logger.info("Test skipped because PICS FAN.S.F03 is not set")
+            return
+
         endpoint = self.user_params.get("endpoint", 1)
 
         self.print_step(1, "Commissioning, already done")

diff --git a/src/python_testing/TC_FAN_3_5.py b/src/python_testing/TC_FAN_3_5.py
@@ -59,10 +59,14 @@ async def send_step_command(self, endpoint,
             pass
 
     def pics_TC_FAN_3_5(self) -> list[str]:
-        return ["FAN.S", "FAN.S.F04"]
+        return ["FAN.S"]
 
     @async_test_body
     async def test_TC_FAN_3_5(self):
+        if not self.check_pics("FAN.S.F04"):
+            logger.info("Test skipped because PICS FAN.S.F04 is not set")
+            return
+
         endpoint = self.user_params.get("endpoint", 1)
 
         # Part 1