Skip to content

Commit

Permalink
[tools] Try to fix bloat check when comment has empty cell
Browse files Browse the repository at this point in the history
The bloat check has been failing for months now because
gh_report.py script seems to assume that the first row
in a comment to the analyzed PR has no empty cells, and
for the cc32xx platform, which happens to finish the build
as the first one, a row with a blank section name is added.

I don't know what is the reason of the blank section, but
the script should not give up just because of one invalid
entry as we miss important code size increase warnings.
  • Loading branch information
Damian-Nordic committed May 10, 2023
1 parent 95acf3d commit d9e3652
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/tools/memory/memdf/util/markdown.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def read_hierified(f):
for i in range(0, len(header)):
column = columns[i + 1].strip()
if not column:
column = rows[-1][i]
column = rows[-1][i] if len(rows) > 0 else '(blank)'
row.append(column)
rows.append(tuple(row))

Expand Down

0 comments on commit d9e3652

Please sign in to comment.