Update the yaml parser to be stricter regarding response configuration (

#8751) * Tests - Update the yaml parser to be stricter regarding response configuration * Update generated tests
project-chip · Sep 13, 2021 · ba56683 · ba56683
1 parent 2c48fbc
commit ba56683
Show file tree

Hide file tree

Showing 8 changed files with 1,166 additions and 4,084 deletions.
diff --git a/examples/chip-tool/commands/tests/Commands.h b/examples/chip-tool/commands/tests/Commands.h
diff --git a/src/app/tests/suites/TV_ApplicationBasicCluster.yaml b/src/app/tests/suites/TV_ApplicationBasicCluster.yaml
@@ -26,39 +26,42 @@ tests:
               - name: "status"
                 value: 1
 
+    # TODO: Support chars validation
     - label: "Read attribute vendor name"
+      disabled: true
       command: "readAttribute"
       attribute: "vendor name"
+      response:
+          value: "exampleVendorName1"
 
-      # TODO: Support chars validation
-      # response:
-      #     value: "exampleVendorName1"
     - label: "Read attribute vendor id"
       command: "readAttribute"
       attribute: "vendor id"
       response:
           value: 1
 
+    # TODO: Support chars validation
     - label: "Read attribute name"
+      disabled: true
       command: "readAttribute"
       attribute: "application name"
+      response:
+          value: "exampleName1"
 
-      # TODO: Support chars validation
-      # response:
-      #     value: "exampleName1"
     - label: "Read attribute product id"
       command: "readAttribute"
       attribute: "product id"
       response:
           value: 1
 
+    # TODO: Support chars validation
     - label: "Read attribute id"
+      disabled: true
       command: "readAttribute"
       attribute: "application id"
+      response:
+          value: "appId"
 
-      # TODO: Support chars validation
-      # response:
-      #     value: "appId"
     - label: "Read attribute catalog vendor id"
       command: "readAttribute"
       attribute: "catalog vendor id"

diff --git a/src/app/tests/suites/certification/Test_TC_CC_3_4.yaml b/src/app/tests/suites/certification/Test_TC_CC_3_4.yaml
@@ -49,10 +49,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
-    #      response:
-    #          value: 150
+      response:
+          value: 150
 
     - label: "Move to hue longest distance command"
       command: "MoveToHue"
@@ -72,10 +73,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
-    #      response:
-    #          value: 150
+      response:
+          value: 150
 
     - label: "Move to hue up command"
       command: "MoveToHue"
@@ -95,10 +97,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
-    #      response:
-    #          value: 250
+      response:
+          value: 250
 
     - label: "Move to hue down command"
       command: "MoveToHue"
@@ -118,10 +121,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
-    #      response:
-    #          value: 225
+      response:
+          value: 225
 
     - label: "Move hue up command"
       command: "MoveHue"
@@ -139,8 +143,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
+      response:
+          value: -1
 
     - label: "Move hue stop command"
       command: "MoveHue"
@@ -158,8 +165,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
+      response:
+          value: -1
 
     - label: "Move hue down command"
       command: "MoveHue"
@@ -177,8 +187,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
+      response:
+          value: -1
 
     - label: "Move hue stop command"
       command: "MoveHue"
@@ -196,8 +209,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
+      response:
+          value: -1
 
     - label: "Step hue up command"
       command: "StepHue"
@@ -217,8 +233,11 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
+      response:
+          value: -1
 
     - label: "Step hue down command"
       command: "StepHue"
@@ -238,14 +257,18 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
+      response:
+          value: -1
 
     - label: "Check Saturation attribute value matched before any change"
+      disabled: true
       command: "readAttribute"
       attribute: "current saturation"
-    #      response:
-    #          value: 90
+      response:
+          value: 90
 
     - label: "Move to saturation command"
       command: "MoveToSaturation"
@@ -263,10 +286,11 @@ tests:
     - label:
           "Check Saturation attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current saturation"
-    #      response:
-    #          value: 90
+      response:
+          value: 90
 
     - label: "Move saturation up command"
       command: "MoveSaturation"
@@ -284,8 +308,11 @@ tests:
     - label:
           "Check Saturation attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current saturation"
+      response:
+          value: -1
 
     - label: "Move saturation down command"
       command: "MoveSaturation"
@@ -303,8 +330,11 @@ tests:
     - label:
           "Check Saturation attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current saturation"
+      response:
+          value: -1
 
     - label: "Step saturation up command"
       command: "StepSaturation"
@@ -324,8 +354,11 @@ tests:
     - label:
           "Check Saturation attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current saturation"
+      response:
+          value: -1
 
     - label: "Step saturation down command"
       command: "StepSaturation"
@@ -345,8 +378,11 @@ tests:
     - label:
           "Check Saturation attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current saturation"
+      response:
+          value: -1
 
     - label: "Move To current hue and saturation command"
       command: "MoveToHueAndSaturation"
@@ -365,18 +401,20 @@ tests:
     - label:
           "Check current hue attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current hue"
-    #      response:
-    #          value: 40
+      response:
+          value: 40
 
     - label:
           "Check Saturation attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current saturation"
-    #      response:
-    #          value: 160
+      response:
+          value: 160
 
     - label: "Turn off light that we turned on"
       cluster: "On/Off"

diff --git a/src/app/tests/suites/certification/Test_TC_CC_5.yaml b/src/app/tests/suites/certification/Test_TC_CC_5.yaml
@@ -48,17 +48,20 @@ tests:
     - label:
           "Check current y attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current x"
-    #      response:
-    #          value: 200
+      response:
+          value: 200
+
     - label:
           "Check current x attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current y"
-    #      response:
-    #          value: 300
+      response:
+          value: 300
 
     - label: "Move Color command"
       command: "MoveColor"
@@ -76,14 +79,20 @@ tests:
     - label:
           "Check current x attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current x"
+      response:
+          value: -1
 
     - label:
           "Check current y attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current y"
+      response:
+          value: -1
 
     - label: "Stop Move Step command"
       command: "StopMoveStep"
@@ -97,14 +106,20 @@ tests:
     - label:
           "Check current x attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current x"
+      response:
+          value: -1
 
     - label:
           "Check current y attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current y"
+      response:
+          value: -1
 
     - label: "Step Color command"
       command: "StepColor"
@@ -124,14 +139,20 @@ tests:
     - label:
           "Check current x attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current x"
+      response:
+          value: -1
 
     - label:
           "Check current y attribute value matched the value sent by the last
           command"
+      disabled: true
       command: "readAttribute"
       attribute: "current y"
+      response:
+          value: -1
 
     - label: "Turn off light that we turned on"
       cluster: "On/Off"