Skip to content

Commit

Permalink
Fix build of all-clusters-app to not build extraneous things. (#21302)
Browse files Browse the repository at this point in the history
The all-clusters-app .gn file did not say what the default thing to
build is, so we were defaulting to "all targets declared in any .gn
file we depend on".

This led to us compiling address-resolve-tool, for example, in
addition to all-clusters-app.

The fix is to explicitly say what the default thing to build is.

Fixes #21221
  • Loading branch information
bzbarsky-apple authored Jul 28, 2022
1 parent 21e9a11 commit b8af0f0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions examples/all-clusters-app/linux/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,7 @@ group("linux") {
deps += [ ":chip-all-clusters-app" ]
}
}

group("default") {
deps = [ ":linux" ]
}
4 changes: 4 additions & 0 deletions examples/all-clusters-minimal-app/linux/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,7 @@ group("linux") {
deps = []
deps += [ ":chip-all-clusters-minimal-app" ]
}

group("default") {
deps = [ ":linux" ]
}

0 comments on commit b8af0f0

Please sign in to comment.