Skip to content

Commit

Permalink
More DRLC XML updates. (#30560)
Browse files Browse the repository at this point in the history
The spec PR keeps changing.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Jan 26, 2024
1 parent 832fbf1 commit b400f8c
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 67 deletions.
9 changes: 1 addition & 8 deletions src/app/zap-templates/zcl/data-model/chip/drlc-cluster.xml
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,6 @@ limitations under the License.
<item name="NonElectric" value="0x2"/>
</enum>

<enum name="PowerSavingsEnum" type="enum8">
<cluster code="0x0096"/>
<item name="Low" value="0x0"/>
<item name="Medium" value="0x1"/>
<item name="High" value="0x2"/>
</enum>

<struct name="TemperatureControlStruct">
<cluster code="0x0096"/>
<!-- Note: No TemperatureDifference type available yet in ZAP XML -->
Expand All @@ -137,7 +130,7 @@ limitations under the License.

<struct name="PowerSavingsControlStruct">
<cluster code="0x0096"/>
<item fieldId="0" name="PowerSavings" type="PowerSavingsEnum"/>
<item fieldId="0" name="PowerSavings" type="percent" />
</struct>

<struct name="HeatingSourceControlStruct">
Expand Down
8 changes: 1 addition & 7 deletions src/controller/data_model/controller-clusters.matter
Original file line number Diff line number Diff line change
Expand Up @@ -3929,12 +3929,6 @@ provisional client cluster DemandResponseLoadControl = 150 {
kFailed = 12;
}

enum PowerSavingsEnum : enum8 {
kLow = 0;
kMedium = 1;
kHigh = 2;
}

bitmap CancelControlBitmap : bitmap16 {
kRandomEnd = 0x1;
}
Expand Down Expand Up @@ -3983,7 +3977,7 @@ provisional client cluster DemandResponseLoadControl = 150 {
}

struct PowerSavingsControlStruct {
PowerSavingsEnum powerSavings = 0;
percent powerSavings = 0;
}

struct DutyCycleControlStruct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import matter.tlv.Tag
import matter.tlv.TlvReader
import matter.tlv.TlvWriter

class DemandResponseLoadControlClusterPowerSavingsControlStruct(val powerSavings: UInt) {
class DemandResponseLoadControlClusterPowerSavingsControlStruct(val powerSavings: UByte) {
override fun toString(): String = buildString {
append("DemandResponseLoadControlClusterPowerSavingsControlStruct {\n")
append("\tpowerSavings : $powerSavings\n")
Expand All @@ -45,7 +45,7 @@ class DemandResponseLoadControlClusterPowerSavingsControlStruct(val powerSavings
tlvReader: TlvReader
): DemandResponseLoadControlClusterPowerSavingsControlStruct {
tlvReader.enterStructure(tlvTag)
val powerSavings = tlvReader.getUInt(ContextSpecificTag(TAG_POWER_SAVINGS))
val powerSavings = tlvReader.getUByte(ContextSpecificTag(TAG_POWER_SAVINGS))

tlvReader.exitContainer()

Expand Down
14 changes: 2 additions & 12 deletions src/controller/python/chip/clusters/Objects.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions zzz_generated/app-common/app-common/zap-generated/cluster-enums.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b400f8c

Please sign in to comment.