fix lineupInfoTypeEnum naming error and add response.data (#16869)

* fix lineupInfoTypeEnum naming error and add response.data * fix restyled-io and ci errors * using MakeOptional
project-chip · Sep 13, 2023 · ad4ecfb · ad4ecfb
1 parent 1a57e56
commit ad4ecfb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/examples/tv-app/android/java/ChannelManager.cpp b/examples/tv-app/android/java/ChannelManager.cpp
@@ -167,7 +167,7 @@ CHIP_ERROR ChannelManager::HandleGetLineup(AttributeValueEncoder & aEncoder)
             lineupInfo.postalCode = Optional<CharSpan>(postalCode.charSpan());
         }
 
-        jfieldID lineupInfoTypeFild = env->GetFieldID(channelLineupClazz, "lineupInfoTypeEnum", "I");
+        jfieldID lineupInfoTypeFild = env->GetFieldID(channelLineupClazz, "lineupInfoType", "I");
         jint jlineupInfoType        = (env->GetIntField(channelLineupObject, lineupInfoTypeFild));
         lineupInfo.lineupInfoType   = static_cast<app::Clusters::Channel::LineupInfoTypeEnum>(jlineupInfoType);
 
@@ -246,9 +246,6 @@ void ChannelManager::HandleChangeChannel(CommandResponseHelper<ChangeChannelResp
     std::string name(match.data(), match.size());
     JNIEnv * env = JniReferences::GetInstance().GetEnvForCurrentThread();
 
-    ChangeChannelResponseType response;
-    response.data = chip::MakeOptional(CharSpan::fromCharString("data response"));
-
     ChipLogProgress(Zcl, "Received ChannelManager::HandleChangeChannel name %s", name.c_str());
     VerifyOrExit(mChannelManagerObject != nullptr, ChipLogError(Zcl, "mChannelManagerObject null"));
     VerifyOrExit(mChangeChannelMethod != nullptr, ChipLogError(Zcl, "mChangeChannelMethod null"));
@@ -268,10 +265,20 @@ void ChannelManager::HandleChangeChannel(CommandResponseHelper<ChangeChannelResp
 
         jclass channelClass = env->GetObjectClass(channelObject);
 
+        ChangeChannelResponseType response;
+
         jfieldID getStatusField = env->GetFieldID(channelClass, "status", "I");
         jint jstatus            = env->GetIntField(channelObject, getStatusField);
         response.status         = static_cast<app::Clusters::Channel::StatusEnum>(jstatus);
 
+        jfieldID getNameField = env->GetFieldID(channelClass, "name", "Ljava/lang/String;");
+        jstring jname         = static_cast<jstring>(env->GetObjectField(channelObject, getNameField));
+        JniUtfString junitname(env, jname);
+        if (jname != NULL)
+        {
+            response.data = MakeOptional(junitname.charSpan());
+        }
+
         helper.Success(response);
     }
 

diff --git a/examples/tv-app/android/java/src/com/tcl/chip/tvapp/ChannelInfo.java b/examples/tv-app/android/java/src/com/tcl/chip/tvapp/ChannelInfo.java
@@ -19,11 +19,11 @@
 
 public class ChannelInfo {
 
-  public static final int kNoError = -1; // todo: what will be the value of no error?
+  public static final int kSuccess = -1; // todo: what will be the value of no error?
   public static final int kMultipleMatches = 0;
   public static final int kNoMatches = 1;
 
-  public int errorType;
+  public int status;
   public int majorNumber;
   public int minorNumber;
   public String name;
@@ -32,23 +32,23 @@ public class ChannelInfo {
 
   public ChannelInfo(
       int majorNumber, int minorNumber, String name, String callSign, String affiliateCallSign) {
-    this.errorType = kNoError;
+    this.status = kSuccess;
     this.majorNumber = majorNumber;
     this.minorNumber = minorNumber;
     this.name = name;
     this.callSign = callSign;
     this.affiliateCallSign = affiliateCallSign;
   }
 
-  public ChannelInfo(int errorType) {
-    this.errorType = errorType;
+  public ChannelInfo(int status) {
+    this.status = status;
   }
 
   @Override
   public String toString() {
     return "ChannelInfo{"
-        + "errorType="
-        + errorType
+        + "status="
+        + status
         + ", majorNumber="
         + majorNumber
         + ", minorNumber="