Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Fix typos

Co-authored-by: Boris Zbarsky <[email protected]>
  • Loading branch information
Morozov-5F and bzbarsky-apple authored May 26, 2022
1 parent 320da62 commit ac71792
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions examples/lock-app/efr32/src/LockManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ bool LockManager::GetUser(uint16_t userIndex, EmberAfPluginDoorLockUserInfo & us
user.userUniqueId = userInDb.userUniqueId;
user.userType = userInDb.userType;
user.credentialRule = userInDb.credentialRule;
// So far there's no way to actually create the credential outside the matter, so here we always set the creation/modification
// So far there's no way to actually create the credential outside Matter, so here we always set the creation/modification
// source to Matter
user.creationSource = DlAssetSource::kMatterIM;
user.createdBy = userInDb.createdBy;
Expand Down Expand Up @@ -322,7 +322,7 @@ bool LockManager::GetCredential(chip::EndpointId endpointId, uint16_t credential
}
credential.credentialType = credentialInStorage.credentialType;
credential.credentialData = credentialInStorage.credentialData;
// So far there's no way to actually create the credential outside the matter, so here we always set the creation/modification
// So far there's no way to actually create the credential outside Matter, so here we always set the creation/modification
// source to Matter
credential.creationSource = DlAssetSource::kMatterIM;
credential.modificationSource = DlAssetSource::kMatterIM;
Expand Down
2 changes: 1 addition & 1 deletion src/app/clusters/door-lock-server/door-lock-server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1455,7 +1455,7 @@ bool DoorLockServer::findOccupiedCredentialSlot(chip::EndpointId endpointId, DlC
return false;
}

// Programming PIN index starts with 0, and it is assumed that it is unique. Therefor different bounds checking for that
// Programming PIN index starts with 0, and it is assumed that it is unique. Therefore different bounds checking for that
// credential type
if (DlCredentialType::kProgrammingPIN == credentialType)
{
Expand Down
2 changes: 1 addition & 1 deletion src/app/clusters/door-lock-server/door-lock-server.h
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ struct EmberAfPluginDoorLockCredentialInfo
chip::ByteSpan credentialData; /**< Credential data bytes. */

DlAssetSource creationSource;
chip::FabricIndex createdBy; /**< ID of the fabric that created the user. */
chip::FabricIndex createdBy; /**< Index of the fabric that created the user. */

DlAssetSource modificationSource;
chip::FabricIndex lastModifiedBy; /**< ID of the fabric that modified the user. */
Expand Down

0 comments on commit ac71792

Please sign in to comment.