Fix tests - they were not testing right.

project-chip · Jun 29, 2021 · ab1b0d1 · ab1b0d1
1 parent 82ee47e
commit ab1b0d1
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/src/lib/mdns/minimal/tests/TestResponseSender.cpp b/src/lib/mdns/minimal/tests/TestResponseSender.cpp
@@ -23,6 +23,7 @@
 #include <mdns/minimal/responders/Ptr.h>
 #include <mdns/minimal/responders/Srv.h>
 #include <mdns/minimal/responders/Txt.h>
+#include <mdns/minimal/RecordData.h>
 
 #include <support/CHIPMem.h>
 #include <support/UnitTestRegistration.h>
@@ -61,9 +62,22 @@ class CheckOnlyServer : public ServerBase, public ParserDelegate
             // For now, types and names are sufficient for checking that the response sender is sending out the correct records.
             if (data.GetType() == expectedRecord[i]->GetType() && data.GetName() == expectedRecord[i]->GetName())
             {
-                foundRecord[i]   = true;
-                recordIsExpected = true;
-                break;
+                if (data.GetType() == QType::PTR) {
+                    // Check that the internal values are the same
+                    SerializedQNameIterator dataTarget;
+                    ParsePtrRecord(data.GetData(), data.GetData(), &dataTarget);
+                    const PtrResourceRecord* expectedPtr = static_cast<const PtrResourceRecord*>(expectedRecord[i]);
+                    if (dataTarget == expectedPtr->GetPtr()) {
+                        foundRecord[i] = true;
+                        recordIsExpected = true;
+                        break;
+                    }
+                }
+                else {
+                    foundRecord[i]   = true;
+                    recordIsExpected = true;
+                    break;
+                }
             }
         }
         NL_TEST_ASSERT(mInSuite, recordIsExpected);
@@ -89,6 +103,7 @@ class CheckOnlyServer : public ServerBase, public ParserDelegate
             if (expectedRecord[i] == nullptr)
             {
                 expectedRecord[i] = record;
+                foundRecord[i] = false;
                 return;
             }
         }