Skip to content

Commit

Permalink
Log signed vs unsigned for TLV payloads. (#32540)
Browse files Browse the repository at this point in the history
Right now we just log the number when the type is integer.  But people keep being
confused why things don't work when they messed up unsigned vs signed bits.  We should
just log that information.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Apr 15, 2024
1 parent 5ffc523 commit a80b0c7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/app/MessageDef/MessageDefHelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ CHIP_ERROR CheckIMPayload(TLV::TLVReader & aReader, int aDepth, const char * aLa

// TODO: Figure out how to not use PRId64 here, since it's not supported
// on all libcs.
PRETTY_PRINT_SAMELINE("%" PRId64 ", ", value_s64);
PRETTY_PRINT_SAMELINE("%" PRId64 " (signed), ", value_s64);
break;
}

Expand All @@ -151,7 +151,7 @@ CHIP_ERROR CheckIMPayload(TLV::TLVReader & aReader, int aDepth, const char * aLa

// TODO: Figure out how to not use PRIu64 here, since it's not supported
// on all libcs.
PRETTY_PRINT_SAMELINE("%" PRIu64 ", ", value_u64);
PRETTY_PRINT_SAMELINE("%" PRIu64 " (unsigned), ", value_u64);
break;
}

Expand Down

0 comments on commit a80b0c7

Please sign in to comment.