-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Right now warnings are logged and exiting the app would do so with a failure status, but for the server app we never exit it, so never discover that warnings happened. The fix is to just fail on the very first warning. The suppression added on Linux is to enable us to do this without immediately failing tests.
- Loading branch information
1 parent
974a6eb
commit a54fd10
Showing
2 changed files
with
12 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# The Linux server app ends up with a data race in libglib. A race_top | ||
# suppression does not work, since the actual race is inside a memset, so the | ||
# thing on top of the stack is memset. called_from_lib is a narrower | ||
# suppression than a "race" suppression (which would be "libglib anywhere on the | ||
# stack", as opposed to "inside a function TSan intercepts, which was called | ||
# from libglib). | ||
# | ||
# See https://github.com/project-chip/connectedhomeip/issues/14710 for | ||
# addressing this. | ||
called_from_lib:libglib |