Log lengths of strings in payload logging. (#20934)

Logs lengths of UTF-8 strings in chars and octet strings in bytes.
project-chip · Jul 19, 2022 · a488d9a · a488d9a
1 parent 612714f
commit a488d9a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/app/MessageDef/MessageDefHelper.cpp b/src/app/MessageDef/MessageDefHelper.cpp
@@ -171,16 +171,19 @@ CHIP_ERROR CheckIMPayload(TLV::TLVReader & aReader, int aDepth, const char * aLa
     case TLV::kTLVType_UTF8String: {
         char value_s[CHIP_CONFIG_LOG_MESSAGE_MAX_SIZE];
 
+#if CHIP_DETAIL_LOGGING
+        uint32_t readerLen = aReader.GetLength();
+#endif // CHIP_DETAIL_LOGGING
         CHIP_ERROR err = aReader.GetString(value_s, sizeof(value_s));
         VerifyOrReturnError(err == CHIP_NO_ERROR || err == CHIP_ERROR_BUFFER_TOO_SMALL, err);
 
         if (err == CHIP_ERROR_BUFFER_TOO_SMALL)
         {
-            PRETTY_PRINT_SAMELINE("... (byte string too long) ...");
+            PRETTY_PRINT_SAMELINE("... (char string too long: %" PRIu32 " chars) ...", readerLen);
         }
         else
         {
-            PRETTY_PRINT_SAMELINE("\"%s\", ", value_s);
+            PRETTY_PRINT_SAMELINE("\"%s\" (%" PRIu32 " chars), ", value_s, readerLen);
         }
         break;
     }
@@ -218,7 +221,7 @@ CHIP_ERROR CheckIMPayload(TLV::TLVReader & aReader, int aDepth, const char * aLa
             }
         }
 
-        PRETTY_PRINT("]");
+        PRETTY_PRINT("] (%" PRIu32 " bytes)", readerLen);
         break;
     }