Skip to content

Commit

Permalink
Fix for test hanging when no ProductID/VendorID is present (#33546)
Browse files Browse the repository at this point in the history
  • Loading branch information
adamb-q authored and pull[bot] committed Jun 18, 2024
1 parent a7981ab commit 95bae5e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/crypto/tests/TestChipCryptoPAL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2804,8 +2804,8 @@ TEST_F(TestChipCryptoPAL, TestVIDPID_x509Extraction)
AttestationCertVidPid vidpid;
CHIP_ERROR result = ExtractVIDPIDFromX509Cert(testCase.cert, vidpid);
EXPECT_EQ(result, testCase.expectedResult);
EXPECT_EQ(vidpid.mVendorId.HasValue(), testCase.expectedVidPresent);
EXPECT_EQ(vidpid.mProductId.HasValue(), testCase.expectedPidPresent);
ASSERT_EQ(vidpid.mVendorId.HasValue(), testCase.expectedVidPresent);
ASSERT_EQ(vidpid.mProductId.HasValue(), testCase.expectedPidPresent);

// If present, make sure the VID matches expectation.
if (testCase.expectedVidPresent)
Expand Down

0 comments on commit 95bae5e

Please sign in to comment.