Cleaned a few comments

project-chip · Nov 9, 2021 · 93191eb · 93191eb
1 parent 0502228
commit 93191eb
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 52 deletions.
diff --git a/examples/lighting-app/python/README.md b/examples/lighting-app/python/README.md
@@ -9,7 +9,6 @@ cd ~/connectedhomeip/
 git submodule update --init
 source scripts/activate.sh
 
-#./scripts/build_python_device.sh --chip_mdns platform --chip_detail_logging true
 ./scripts/build_python_device.sh --chip_detail_logging true
 
 sudo su # dhclient is called, needs root

diff --git a/examples/lighting-app/python/lighting.py b/examples/lighting-app/python/lighting.py
@@ -20,7 +20,6 @@
     PostAttributeChangeCallback,
 )
 
-# from chip.server.types import PostAttributeChangeCallback
 from chip.exceptions import ChipStackError
 
 from ctypes import CFUNCTYPE, c_char_p, c_int32, c_uint8
@@ -48,9 +47,7 @@ async def dali_on(is_on: bool):
     global dali_loop
     global dev
 
-    #print("Waiting for device...")
     await dev.connected.wait()
-    #print(f"Connected, firmware={dev.firmware_version}, serial={dev.serial}")
     if (is_on):
         await dev.send(RecallMaxLevel(Broadcast()))
     else:
@@ -61,9 +58,7 @@ async def dali_level(level: int):
     global dali_loop
     global dev
 
-    #print("Waiting for device...")
     await dev.connected.wait()
-    #print(f"Connected, firmware={dev.firmware_version}, serial={dev.serial}")
     await dev.send(DAPC(Broadcast(), level))
 
 
@@ -95,17 +90,6 @@ def __init__(self, rendezvousAddr=None, controllerNodeId=0, bluetoothAdapter=Non
 
         LightingMgrCmd.command_names.sort()
 
-        # self.bleMgr = None
-
-        # self.devCtrl = ChipDeviceCtrl.ChipDeviceController(
-        #     controllerNodeId=controllerNodeId, bluetoothAdapter=bluetoothAdapter
-        # )
-
-        # # If we are on Linux and user selects non-default bluetooth adapter.
-        # if sys.platform.startswith("linux") and (bluetoothAdapter is not None):
-        #     self.bleMgr = BleManager(self.devCtrl)
-        #     self.bleMgr.ble_adapter_select("hci{}".format(bluetoothAdapter))
-
         self.historyFileName = os.path.expanduser("~/.chip-lighting-history")
 
         try:
@@ -123,20 +107,6 @@ def __init__(self, rendezvousAddr=None, controllerNodeId=0, bluetoothAdapter=Non
 
     command_names = [
         "help"
-        # "setup-payload",
-        # "ble-scan",
-        # "ble-adapter-select",
-        # "ble-adapter-print",
-        # "ble-debug-log",
-        # "connect",
-        # "close-ble",
-        # "resolve",
-        # "zcl",
-        # "zclread",
-        # "zclconfigure",
-        # "discover",
-        # "set-pairing-wifi-credential",
-        # "set-pairing-thread-credential",
     ]
 
     def parseline(self, line):
@@ -213,18 +183,6 @@ def attributeChangeCallback(
     size: int,
     value: bytes,
 ):
-    # print(
-    #     "[PY] AttributeChangeCallback endpoint {} clusterId {} attributeId {} mask {} manufacturerCode {} type {} size {} value {}".format(
-    #         endpoint,
-    #         clusterId,
-    #         attributeId,
-    #         mask,
-    #         manufacturerCode,
-    #         xx_type,
-    #         size,
-    #         value,
-    #     )
-    # )
     global dali_loop
     if endpoint == 1:
         if clusterId == 6 and attributeId == 0:

diff --git a/scripts/build_python_device.sh b/scripts/build_python_device.sh
@@ -99,16 +99,12 @@ echo "Input values: chip_detail_logging = $chip_detail_logging , chip_mdns = \"$
 # Ensure we have a compilation environment
 source "$CHIP_ROOT/scripts/activate.sh"
 
-echo "***** mab : activate done"
-
 # Generates ninja files
 [[ -n "$chip_mdns" ]] && chip_mdns_arg="chip_mdns=\"$chip_mdns\"" || chip_mdns_arg=""
 
 chip_data_model_arg="chip_data_model=\"///examples/lighting-app/lighting-common\""
 
-gn --root="$CHIP_ROOT" gen "$OUTPUT_ROOT" --args="chip_detail_logging=$chip_detail_logging enable_pylib=$enable_pybindings enable_rtti=$enable_pybindings chip_use_clusters_for_ip_commissioning=$clusters $chip_mdns_arg chip_python_controller=false $chip_data_model_arg"
-
-echo "***** mab : gn done"
+gn --root="$CHIP_ROOT" gen "$OUTPUT_ROOT" --args="chip_detail_logging=$chip_detail_logging enable_pylib=$enable_pybindings enable_rtti=$enable_pybindings chip_use_clusters_for_ip_commissioning=$clusters $chip_mdns_arg chip_controller=false $chip_data_model_arg"
 
 # Compiles python files
 # Check pybindings was requested
@@ -118,13 +114,9 @@ else
     ninja -v -C "$OUTPUT_ROOT" python
 fi
 
-echo "***** mab : ninja done"
-
 # Create a virtual environment that has access to the built python tools
 virtualenv --clear "$ENVIRONMENT_ROOT"
 
-echo "***** mab : venv done"
-
 # Activate the new environment to register the python WHL
 
 if [ "$enable_pybindings" == true ]; then