Add more comments

project-chip · Jan 27, 2022 · 926ccc5 · 926ccc5
1 parent 12f8b40
commit 926ccc5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/lib/core/Optional.h b/src/lib/core/Optional.h
@@ -68,10 +68,13 @@ class Optional
     {
         if (mHasValue)
         {
+            // The -Wmaybe-uninitialized warning gets confused about the fact
+            // that other.mValue is always initialized if other.mHasValue is
+            // true, so suppress it for our access to other.mValue.
 #pragma GCC diagnostic push
 #if !defined(__clang__)
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-#endif
+#endif // !defined(__clang__)
             new (&mValue.mData) T(other.mValue.mData);
 #pragma GCC diagnostic pop
         }