Do not stop minmdns browse after the first result found

project-chip · Jun 7, 2024 · 916ebd2 · 916ebd2
1 parent 4239c88
commit 916ebd2
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 28 deletions.
diff --git a/src/lib/dnssd/ActiveResolveAttempts.cpp b/src/lib/dnssd/ActiveResolveAttempts.cpp
@@ -53,30 +53,6 @@ void ActiveResolveAttempts::Complete(const PeerId & peerId)
 #endif
 }
 
-void ActiveResolveAttempts::CompleteCommissioner(const chip::Dnssd::DiscoveredNodeData & data)
-{
-    for (auto & item : mRetryQueue)
-    {
-        if (item.attempt.Matches(data, chip::Dnssd::DiscoveryType::kCommissionerNode))
-        {
-            item.attempt.Clear();
-            return;
-        }
-    }
-}
-
-void ActiveResolveAttempts::CompleteCommissionable(const chip::Dnssd::DiscoveredNodeData & data)
-{
-    for (auto & item : mRetryQueue)
-    {
-        if (item.attempt.Matches(data, chip::Dnssd::DiscoveryType::kCommissionableNode))
-        {
-            item.attempt.Clear();
-            return;
-        }
-    }
-}
-
 bool ActiveResolveAttempts::HasBrowseFor(chip::Dnssd::DiscoveryType type) const
 {
     for (auto & item : mRetryQueue)

diff --git a/src/lib/dnssd/ActiveResolveAttempts.h b/src/lib/dnssd/ActiveResolveAttempts.h
@@ -250,8 +250,6 @@ class ActiveResolveAttempts
 
     /// Mark a resolution as a success, removing it from the internal list
     void Complete(const chip::PeerId & peerId);
-    void CompleteCommissioner(const chip::Dnssd::DiscoveredNodeData & data);
-    void CompleteCommissionable(const chip::Dnssd::DiscoveredNodeData & data);
     void CompleteIpResolution(SerializedQNameIterator targetHostName);
 
     /// Mark all browse-type scheduled attemptes as a success, removing them

diff --git a/src/lib/dnssd/Resolver_ImplMinimalMdns.cpp b/src/lib/dnssd/Resolver_ImplMinimalMdns.cpp
@@ -424,11 +424,9 @@ void MinMdnsResolver::AdvancePendingResolverStates()
             {
             case IncrementalResolver::ServiceNameType::kCommissioner:
                 discoveredNodeIsRelevant = mActiveResolves.HasBrowseFor(chip::Dnssd::DiscoveryType::kCommissionerNode);
-                mActiveResolves.CompleteCommissioner(nodeData);
                 break;
             case IncrementalResolver::ServiceNameType::kCommissionable:
                 discoveredNodeIsRelevant = mActiveResolves.HasBrowseFor(chip::Dnssd::DiscoveryType::kCommissionableNode);
-                mActiveResolves.CompleteCommissionable(nodeData);
                 break;
             default:
                 ChipLogError(Discovery, "Unexpected type for browse data parsing");