Address comments

project-chip · Jan 20, 2022 · 86ae34c · 86ae34c
1 parent a8f9798
commit 86ae34c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap b/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
@@ -16363,7 +16363,7 @@
               "mfgCode": null,
               "side": "server",
               "included": 1,
-              "storageOption": "RAM",
+              "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
               "defaultValue": "",

diff --git a/src/app/clusters/test-cluster-server/test-cluster-server.cpp b/src/app/clusters/test-cluster-server/test-cluster-server.cpp
@@ -412,7 +412,6 @@ CHIP_ERROR TestAttrAccess::WriteStructAttribute(AttributeValueDecoder & aDecoder
 CHIP_ERROR TestAttrAccess::ReadListFabricScopedAttribute(AttributeValueEncoder & aEncoder)
 {
     return aEncoder.EncodeList([](const auto & encoder) -> CHIP_ERROR {
-        // Just encode our one struct for now.
         auto fabricTable = Server::GetInstance().GetFabricTable();
 
         chip::app::Clusters::TestCluster::Structs::TestFabricScoped::Type val;
@@ -424,7 +423,7 @@ CHIP_ERROR TestAttrAccess::ReadListFabricScopedAttribute(AttributeValueEncoder &
         }
 
         // Always append a fake fabric index so we can test fabric filter even when there is only one fabric provisioned.
-        val.fabricIndex = 0xFF;
+        val.fabricIndex = kUndefinedFabricIndex;
         ReturnErrorOnFailure(encoder.Encode(val));
         return CHIP_NO_ERROR;
     });