Skip to content

Commit

Permalink
Add Constants.h to the secure_channel sources. (#28219)
Browse files Browse the repository at this point in the history
This causes gn to correctly notice the circular dependencies between
secure_channel and messaging and secure_channel and transport, which are
inherent in the spec.  Annotate those circular dependencies.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Sep 14, 2023
1 parent 42eb46c commit 80dc946
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions src/protocols/secure_channel/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ static_library("secure_channel") {
"CASEServer.h",
"CASESession.cpp",
"CASESession.h",
"Constants.h",
"DefaultSessionResumptionStorage.cpp",
"DefaultSessionResumptionStorage.h",
"PASESession.cpp",
Expand Down Expand Up @@ -38,5 +39,18 @@ static_library("secure_channel") {
"${chip_root}/src/system",
"${chip_root}/src/tracing",
"${chip_root}/src/tracing:macros",
"${chip_root}/src/transport",
]

# secure channel requires messaging so it can send messages (e.g. for
# CASE/PASE handshakes). messaging requires secure channel so that it can do
# things like send standalone acks, which are a secure channel concept.
#
# secure channel requires transport so it can deal with sessions. transport
# requires secure channel so it can detect control messages, which are a
# secure channel concept.
allow_circular_includes_from = [
"${chip_root}/src/messaging",
"${chip_root}/src/transport",
]
}

0 comments on commit 80dc946

Please sign in to comment.