Skip to content

Commit

Permalink
Clarify logging during MRP retransmit backoff computation. (#37369)
Browse files Browse the repository at this point in the history
The log sounded like a retransmit was happening, but it's actually saying that a
retransmit is scheduled.  The retransmit might or might not happen, depending on
whether we get an ack before the scheduled time.
  • Loading branch information
bzbarsky-apple authored Feb 4, 2025
1 parent 0d27f42 commit 7912cad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/messaging/ReliableMessageMgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,8 @@ void ReliableMessageMgr::CalculateNextRetransTime(RetransTableEntry & entry)

ChipLogProgress(ExchangeManager,
"??%d [E:" ChipLogFormatExchange " S:%u M:" ChipLogFormatMessageCounter
"] (%s) Msg Retransmission to %u:" ChipLogFormatX64 " in %" PRIu32 "ms [State:%s II:%" PRIu32 " AI:%" PRIu32
" AT:%u]",
"] (%s) Msg Retransmission to %u:" ChipLogFormatX64 " scheduled for %" PRIu32
"ms from now [State:%s II:%" PRIu32 " AI:%" PRIu32 " AT:%u]",
entry.sendCount + 1, ChipLogValueExchange(&entry.ec.Get()), sessionHandle->SessionIdForLogging(),
messageCounter, Transport::GetSessionTypeString(sessionHandle), fabricIndex, ChipLogValueX64(destination),
backoff.count(), peerIsActive ? "Active" : "Idle", config.mIdleRetransTimeout.count(),
Expand Down

0 comments on commit 7912cad

Please sign in to comment.