Merge branch 'master' into fix-runner

.github/workflows/stale.yaml

@@ -0,0 +1,42 @@
+name: "Process Stale Issues and PRs"
+on:
+    workflow_dispatch:
+    schedule:
+        - cron: "30 1 * * *"
+
+permissions:
+    issues: write
+    pull-requests: write
+
+jobs:
+    stale:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/stale@v9
+              with:
+                  stale-issue-message:
+                      "This issue has been automatically marked as stale because
+                      it has not had recent activity. It will be closed if no
+                      further activity occurs. Remove stale label or comment or
+                      this will be closed in 30 days."
+                  stale-pr-message:
+                      "This pull request has been automatically marked as stale
+                      because it has not had recent activity. It will be closed
+                      if no further activity occurs. Remove stale label or
+                      comment or this will be closed in 10 days."
+                  close-issue-message:
+                      "This stale issue has been automatically closed. Thank you
+                      for your contributions."
+                  close-pr-message:
+                      "This stale pull request has been automatically closed.
+                      Thank you for your contributions."
+                  days-before-issue-stale: 30
+                  days-before-issue-close: -1 # Don't close them for now
+                  days-before-pr-stale: 90
+                  days-before-pr-close: 10
+                  exempt-issue-labels:
+                      "security,blocked,cert blocker,build issue,Spec XML
+                      align,CI/CD improvements,memory"
+                  exempt-pr-labels:
+                      "security,blocked,cert blocker,build issue,Spec XML
+                      align,CI/CD improvements,memory"

docs/cluster_and_device_type_dev/cluster_and_device_type_dev.md

@@ -107,9 +107,9 @@ ending in the cluster initialization code.
 EmberAfInitializeAttributes - ember attribute storage - for all attributes
 marked as “RAM” in the zap, sets defaults in the storage
 Matter<Cluster>PluginServerCallback - .h is a generated file, .cpp impl is done
-in the server cluster code. Use this to setup the cluster and do attribute
-overrides registerAttributeAccessOverride - use this if you want to handle
-attribute reads and writes externally
+in the server cluster code. Use this to setup the cluster and setup overrides in
+chip::app::AttributeAccessInterfaceRegistry::Instance().Register - use this if
+you want to handle attribute reads and writes externally
 
 Blue sections can be overridden.
 

docs/testing/yaml_schema.md

@@ -62,6 +62,7 @@ YAML schema
 |      hasMasksClear |list||
 |      notValue |NoneType,bool,int,float,list,dict|Y|
 |      anyOf |list||
+|      python |str|Y|
 |    saveAs |str||
 |    saveDataVersschemaionAs |str||
 |  saveResponseAs |str||

docs/upgrading.md

@@ -69,10 +69,26 @@ independent of the InteractionModelEngine class.
 The following replacements exist:
 
 -   `chip::app::InteractionModelEngine::RegisterCommandHandler` replaced by
-    `chip::app::CommandHandlerInterfaceRegistry::RegisterCommandHandler`
+    `chip::app::CommandHandlerInterfaceRegistry::Instance().RegisterCommandHandler`
 -   `chip::app::InteractionModelEngine::UnregisterCommandHandler` replaced by
-    `chip::app::CommandHandlerInterfaceRegistry::UnregisterCommandHandler`
+    `chip::app::CommandHandlerInterfaceRegistry::Instance().UnregisterCommandHandler`
 -   `chip::app::InteractionModelEngine::FindCommandHandler` replaced by
-    `chip::app::CommandHandlerInterfaceRegistry::GetCommandHandler`
+    `chip::app::CommandHandlerInterfaceRegistry::Instance().GetCommandHandler`
 -   `chip::app::InteractionModelEngine::UnregisterCommandHandlers` replaced by
-    `chip::app::CommandHandlerInterfaceRegistry::UnregisterAllCommandHandlersForEndpoint`
+    `chip::app::CommandHandlerInterfaceRegistry::Instance().UnregisterAllCommandHandlersForEndpoint`
+
+### AttributeAccessInterface registration and removal
+
+A new object exists for the attribute access interface registry, accessible as
+`chip::app::AttributeHandlerInterfaceRegistry::Instance()`
+
+Replacements for methods are:
+
+-   `registerAttributeAccessOverride` replaced by
+    `chip::app::AttributeAccessInterfaceRegistry::Instance().Register`
+-   `unregisterAttributeAccessOverride` replaced by
+    `chip::app::AttributeAccessInterfaceRegistry::Instance().Unregister`
+-   `unregisterAllAttributeAccessOverridesForEndpoint` replaced by
+    `chip::app::AttributeAccessInterfaceRegistry::Instance().UnregisterAllForEndpoint`
+-   `chip::app::GetAttributeAccessOverride` replaced by
+    `chip::app::AttributeAccessInterfaceRegistry::Instance().Get`

examples/all-clusters-app/all-clusters-common/src/bridged-actions-stub.cpp

@@ -98,5 +98,5 @@ CHIP_ERROR ActionsAttrAccess::Read(const ConcreteReadAttributePath & aPath, Attr
 
 void MatterActionsPluginServerInitCallback()
 {
-    registerAttributeAccessOverride(&gAttrAccess);
+    AttributeAccessInterfaceRegistry::Instance().Register(&gAttrAccess);
 }

examples/all-clusters-app/all-clusters-common/src/fan-stub.cpp

@@ -173,6 +173,6 @@ void emberAfFanControlClusterInitCallback(EndpointId endpoint)
 {
     VerifyOrDie(mFanControlManager == nullptr);
     mFanControlManager = new FanControlManager(endpoint);
-    registerAttributeAccessOverride(mFanControlManager);
+    AttributeAccessInterfaceRegistry::Instance().Register(mFanControlManager);
     FanControl::SetDefaultDelegate(endpoint, mFanControlManager);
 }

examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter

@@ -5583,6 +5583,9 @@ cluster ApplicationLauncher = 1292 {
     kSuccess = 0;
     kAppNotAvailable = 1;
     kSystemBusy = 2;
+    kPendingUserApproval = 3;
+    kDownloading = 4;
+    kInstalling = 5;
   }
 
   bitmap Feature : bitmap32 {

examples/bridge-app/asr/src/bridged-actions-stub.cpp

@@ -97,5 +97,5 @@ CHIP_ERROR ActionsAttrAccess::Read(const ConcreteReadAttributePath & aPath, Attr
 
 void MatterActionsPluginServerInitCallback(void)
 {
-    registerAttributeAccessOverride(&gAttrAccess);
+    AttributeAccessInterfaceRegistry::Instance().Register(&gAttrAccess);
 }

examples/bridge-app/esp32/main/DeviceCallbacks.cpp

@@ -113,5 +113,5 @@ CHIP_ERROR ActionsAttrAccess::Read(const ConcreteReadAttributePath & aPath, Attr
 
 void MatterActionsPluginServerInitCallback(void)
 {
-    registerAttributeAccessOverride(&gAttrAccess);
+    AttributeAccessInterfaceRegistry::Instance().Register(&gAttrAccess);
 }

examples/bridge-app/linux/bridged-actions-stub.cpp

@@ -133,5 +133,5 @@ CHIP_ERROR ActionsAttrAccess::Read(const ConcreteReadAttributePath & aPath, Attr
 
 void MatterActionsPluginServerInitCallback()
 {
-    registerAttributeAccessOverride(&gAttrAccess);
+    AttributeAccessInterfaceRegistry::Instance().Register(&gAttrAccess);
 }

examples/bridge-app/linux/main.cpp

@@ -998,7 +998,7 @@ void ApplicationInit()
         }
     }
 
-    registerAttributeAccessOverride(&gPowerAttrAccess);
+    AttributeAccessInterfaceRegistry::Instance().Register(&gPowerAttrAccess);
 }
 
 void ApplicationShutdown() {}

examples/bridge-app/telink/src/DeviceCallbacks.cpp

@@ -101,5 +101,5 @@ CHIP_ERROR ActionsAttrAccess::Read(const ConcreteReadAttributePath & aPath, Attr
 
 void MatterActionsPluginServerInitCallback(void)
 {
-    registerAttributeAccessOverride(&gAttrAccess);
+    AttributeAccessInterfaceRegistry::Instance().Register(&gAttrAccess);
 }

examples/chef/common/chef-concentration-measurement.cpp

@@ -91,7 +91,7 @@ Protocols::InteractionModel::Status chefConcentrationMeasurementWriteCallback(
         CHIP_ERROR err = clusterInstance->SetMeasuredValue(MakeNullable(newValue));
         if (CHIP_NO_ERROR == err)
         {
-            ChipLogDetail(DeviceLayer, "Updated EP:%d, Cluster: 0x%04x to MeasuredValue: %f", endpoint, clusterId, newValue);
+            ChipLogDetail(DeviceLayer, "Updated EP:%d, Cluster: 0x%04x MeasuredValue", endpoint, clusterId);
         }
         else
         {

examples/chef/common/chef-fan-control-manager.cpp

@@ -141,6 +141,6 @@ void emberAfFanControlClusterInitCallback(EndpointId endpoint)
 {
     VerifyOrDie(!mFanControlManager);
     mFanControlManager = std::make_unique<ChefFanControlManager>(endpoint);
-    registerAttributeAccessOverride(mFanControlManager.get());
+    AttributeAccessInterfaceRegistry::Instance().Register(mFanControlManager.get());
     FanControl::SetDefaultDelegate(endpoint, mFanControlManager.get());
 }

examples/chef/common/chef-rpc-actions-worker.cpp

@@ -147,7 +147,9 @@ void ChefRpcActionsWorker::RegisterRpcActionsDelegate(ClusterId clusterId, Actio
 
 ChefRpcActionsWorker::ChefRpcActionsWorker()
 {
+#if CONFIG_ENABLE_PW_RPC
     chip::rpc::SubscribeActions(ChefRpcActionsCallback);
+#endif
 }
 
 static ChefRpcActionsWorker instance;

examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter

@@ -2726,7 +2726,7 @@ endpoint 1 {
     ram      attribute credentialRulesSupport default = 1;
     ram      attribute numberOfCredentialsSupportedPerUser default = 5;
     ram      attribute language default = "en";
-    ram      attribute autoRelockTime default = 5;
+    ram      attribute autoRelockTime default = 0;
     ram      attribute soundVolume default = 0;
     ram      attribute operatingMode default = 0;
     ram      attribute supportedOperatingModes default = 0xFFFF;

examples/chef/devices/rootnode_doorlock_aNKYAreMXE.zap

@@ -3665,7 +3665,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "5",
+              "defaultValue": "0",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,

examples/energy-management-app/linux/README.md

@@ -1,4 +1,4 @@
-# CHIP Linux Energy Management Example
+# Matter Linux Energy Management Example
 
 An example showing the use of CHIP on the Linux. The document will describe how
 to build and run CHIP Linux Energy Management Example on Raspberry Pi. This doc
@@ -12,7 +12,7 @@ details.
 
 <hr>
 
--   [CHIP Linux Energy Management Example](#chip-linux-energy-management-example)
+-   [Matter Linux Energy Management Example](#matter-linux-energy-management-example)
     -   [Building](#building)
     -   [Commandline arguments](#commandline-arguments)
     -   [Running the Complete Example on Raspberry Pi 4](#running-the-complete-example-on-raspberry-pi-4)

examples/fabric-bridge-app/linux/main.cpp

@@ -32,7 +32,6 @@
 #include "RpcServer.h"
 #endif
 
-#include <string>
 #include <sys/ioctl.h>
 #include <thread>
 
@@ -186,8 +185,8 @@ void ApplicationInit()
     ChipLogDetail(NotSpecified, "Fabric-Bridge: ApplicationInit()");
 
     MatterEcosystemInformationPluginServerInitCallback();
-    CommandHandlerInterfaceRegistry::RegisterCommandHandler(&gAdministratorCommissioningCommandHandler);
-    registerAttributeAccessOverride(&gBridgedDeviceBasicInformationAttributes);
+    CommandHandlerInterfaceRegistry::Instance().RegisterCommandHandler(&gAdministratorCommissioningCommandHandler);
+    AttributeAccessInterfaceRegistry::Instance().Register(&gBridgedDeviceBasicInformationAttributes);
 
 #if defined(PW_RPC_FABRIC_BRIDGE_SERVICE) && PW_RPC_FABRIC_BRIDGE_SERVICE
     InitRpcServer(kFabricBridgeServerPort);

examples/log-source-app/linux/main.cpp

@@ -110,7 +110,7 @@ int main(int argc, char * argv[])
     // Initialize device attestation config
     SetDeviceAttestationCredentialsProvider(chip::Credentials::Examples::GetExampleDACProvider());
 
-    CommandHandlerInterfaceRegistry::RegisterCommandHandler(&GetLogProvider());
+    CommandHandlerInterfaceRegistry::Instance().RegisterCommandHandler(&GetLogProvider());
 
     chip::DeviceLayer::PlatformMgr().RunEventLoop();
 

examples/placeholder/linux/apps/app1/config.matter

@@ -8236,6 +8236,9 @@ cluster ApplicationLauncher = 1292 {
     kSuccess = 0;
     kAppNotAvailable = 1;
     kSystemBusy = 2;
+    kPendingUserApproval = 3;
+    kDownloading = 4;
+    kInstalling = 5;
   }
 
   bitmap Feature : bitmap32 {
@@ -8295,6 +8298,9 @@ cluster ApplicationLauncher = 1292 {
     kSuccess = 0;
     kAppNotAvailable = 1;
     kSystemBusy = 2;
+    kPendingUserApproval = 3;
+    kDownloading = 4;
+    kInstalling = 5;
   }
 
   bitmap Feature : bitmap32 {

examples/placeholder/linux/apps/app2/config.matter

@@ -8193,6 +8193,9 @@ cluster ApplicationLauncher = 1292 {
     kSuccess = 0;
     kAppNotAvailable = 1;
     kSystemBusy = 2;
+    kPendingUserApproval = 3;
+    kDownloading = 4;
+    kInstalling = 5;
   }
 
   bitmap Feature : bitmap32 {
@@ -8252,6 +8255,9 @@ cluster ApplicationLauncher = 1292 {
     kSuccess = 0;
     kAppNotAvailable = 1;
     kSystemBusy = 2;
+    kPendingUserApproval = 3;
+    kDownloading = 4;
+    kInstalling = 5;
   }
 
   bitmap Feature : bitmap32 {

examples/placeholder/linux/src/bridged-actions-stub.cpp

@@ -98,5 +98,5 @@ CHIP_ERROR ActionsAttrAccess::Read(const ConcreteReadAttributePath & aPath, Attr
 
 void MatterActionsPluginServerInitCallback(void)
 {
-    registerAttributeAccessOverride(&gAttrAccess);
+    chip::app::AttributeAccessInterfaceRegistry::Instance().Register(&gAttrAccess);
 }

examples/tv-app/android/App/platform-app/build.gradle

@@ -72,4 +72,4 @@ dependencies {
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
     implementation 'com.google.zxing:core:3.3.0'
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
-}
+}