Fix Global Buffer Overflow in MediaInputManager.cpp

project-chip · Dec 16, 2024 · 6ff0df9 · 6ff0df9
1 parent cfdaf79
commit 6ff0df9
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/examples/tv-app/tv-common/clusters/media-input/MediaInputManager.cpp b/examples/tv-app/tv-common/clusters/media-input/MediaInputManager.cpp
@@ -99,6 +99,11 @@ bool MediaInputManager::HandleRenameInput(const uint8_t index, const chip::CharS
     {
         if (input.index == index)
         {
+            if (sizeof(mCharDataBuffer[index]) < name.size())
+            {
+                return mediaInputRenamed;
+            }
+
             mediaInputRenamed = true;
             memcpy(this->Data(index), name.data(), name.size());
             input.name = chip::CharSpan(this->Data(index), name.size());