Skip to content

Commit

Permalink
Add OperationalState Global Attributes test to the CI (#27950)
Browse files Browse the repository at this point in the history
* Add OperationalState Global Attributes test to the CI

Steps:
- regen all yaml tests
- re-build chip-tool, re-build all-clusters
- manually run OPSTATE_1_1 via chip-tool
- verify resulting logs

* Restyled by whitespace

* Restyled by prettier-json

* Restyled by prettier-yaml

* Revert change to manualtests.json

* Restyled by whitespace

* Restyled by prettier-json

* Exclude test from Darwin

* Restyled by whitespace

* Update with results of regen

* Restyled by whitespace

---------

Co-authored-by: Restyled.io <[email protected]>
  • Loading branch information
2 people authored and pull[bot] committed Jan 30, 2024
1 parent 2e2715f commit 6f49f93
Show file tree
Hide file tree
Showing 6 changed files with 293 additions and 13 deletions.
2 changes: 2 additions & 0 deletions examples/darwin-framework-tool/templates/tests/ciTests.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@
"Disabled due to HEPAFilterMonitoring not being enabled in Matter.framework for now:",
"Test_TC_HEPAFREMON_1_1",
"Test_TC_HEPAFREMON_2_1",
"Disabled due to OperationalState not being enabled in Matter.framework for now:",
"Test_TC_OPSTATE_1_1",
"Disabled due to Events verification not supported",
"Test_TC_BINFO_2_2"
]
Expand Down
24 changes: 24 additions & 0 deletions src/app/tests/suites/certification/PICS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9539,3 +9539,27 @@ PICS:
- label:
"Does the device implement sending the ChangeToModeResponse command?"
id: RVCCLEANMS.S.C03.Tx

#
#Operational State
#
#Server Attributes
- label: "Does the device implement the CountdownTime attribute?"
id: OPSTATE.S.A0002

#Events Generated
- label: "Does the device generate the OperationCompltion event?"
id: OPSTATE.S.E01

#Server Commands Received
- label: "Does the device implement receiving the Pause command?"
id: OPSTATE.S.C00

- label: "Does the device implement receiving the Stop command?"
id: OPSTATE.S.C01

- label: "Does the device implement receiving the Start command?"
id: OPSTATE.S.C02

- label: "Does the device implement receiving the Resume command?"
id: OPSTATE.S.C03
20 changes: 7 additions & 13 deletions src/app/tests/suites/certification/Test_TC_OPSTATE_1_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ tests:
value: nodeId

- label: "TH reads the ClusterRevision attribute from the DUT"
PICS: OPSTATE.S.Afffd
command: "readAttribute"
attribute: "ClusterRevision"
response:
Expand All @@ -41,7 +40,6 @@ tests:
type: int16u

- label: "TH reads the FeatureMap attribute from the DUT"
PICS: OPSTATE.S.Afffc
command: "readAttribute"
attribute: "FeatureMap"
response:
Expand All @@ -50,7 +48,6 @@ tests:
type: bitmap32

- label: "TH reads the AttributeList attribute from the DUT"
PICS: OPSTATE.S.Afffb
command: "readAttribute"
attribute: "AttributeList"
response:
Expand All @@ -62,7 +59,7 @@ tests:
- label:
"TH reads from the DUT the optional attribute(CountdownTime) in the
AttributeList from the DUT"
PICS: OPSTATE.S.A0002 && OPSTATE.S.Afffb
PICS: OPSTATE.S.A0002
command: "readAttribute"
attribute: "AttributeList"
response:
Expand All @@ -71,7 +68,6 @@ tests:
contains: [2]

- label: "TH reads from the DUT the EventList attribute."
PICS: OPSTATE.S.Afffa
command: "readAttribute"
attribute: "EventList"
response:
Expand All @@ -82,7 +78,7 @@ tests:
- label:
"TH reads from the DUT the optional event(OperationCompletion) in
EventList."
PICS: OPSTATE.S.E01 && OPSTATE.S.Afffa
PICS: OPSTATE.S.E01
command: "readAttribute"
attribute: "EventList"
response:
Expand All @@ -91,7 +87,7 @@ tests:
contains: [0x01]

- label: "Read the optional command(Start) in AcceptedCommandList"
PICS: OPSTATE.S.C02 && OPSTATE.S.Afff9
PICS: OPSTATE.S.C02
command: "readAttribute"
attribute: "AcceptedCommandList"
response:
Expand All @@ -100,7 +96,7 @@ tests:
contains: [1, 2]

- label: "Read the optional command(Stop) in AcceptedCommandList"
PICS: OPSTATE.S.C01 && OPSTATE.S.Afff9
PICS: OPSTATE.S.C01
command: "readAttribute"
attribute: "AcceptedCommandList"
response:
Expand All @@ -109,7 +105,7 @@ tests:
contains: [1]

- label: "Read the optional command(Pause) in AcceptedCommandList"
PICS: OPSTATE.S.C00 && OPSTATE.S.Afff9
PICS: OPSTATE.S.C00
command: "readAttribute"
attribute: "AcceptedCommandList"
response:
Expand All @@ -118,7 +114,7 @@ tests:
contains: [0, 3]

- label: "Read the optional command(Resume) in AcceptedCommandList"
PICS: OPSTATE.S.C03 && OPSTATE.S.Afff9
PICS: OPSTATE.S.C03
command: "readAttribute"
attribute: "AcceptedCommandList"
response:
Expand All @@ -127,9 +123,7 @@ tests:
contains: [0, 3]

- label: "Read the global attribute: GeneratedCommandList"
PICS:
OPSTATE.S.Afff8 && (OPSTATE.S.C00 || OPSTATE.S.C01 || OPSTATE.S.C02 ||
OPSTATE.S.C03)
PICS: (OPSTATE.S.C00 || OPSTATE.S.C01 || OPSTATE.S.C02 || OPSTATE.S.C03)
command: "readAttribute"
attribute: "GeneratedCommandList"
response:
Expand Down
13 changes: 13 additions & 0 deletions src/app/tests/suites/certification/ci-pics-values
Original file line number Diff line number Diff line change
Expand Up @@ -1828,6 +1828,19 @@ OPCREDS.C.C09.Tx=1
OPCREDS.C.C0a.Tx=1
OPCREDS.C.C0b.Tx=1

# Operational State
# Server Attributes
OPSTATE.S.A0002=1

# Server Events
OPSTATE.S.E01=1

# Server Commands
OPSTATE.S.C00=1
OPSTATE.S.C01=1
OPSTATE.S.C02=1
OPSTATE.S.C03=1

# Thermostat
# Server
TSTAT.S=1
Expand Down
2 changes: 2 additions & 0 deletions src/app/tests/suites/ciTests.json
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
"Test_TC_OO_2_2",
"Test_TC_OO_2_4"
],
"OperationalState": ["Test_TC_OPSTATE_1_1"],
"PowerSource": ["Test_TC_PS_1_1", "Test_TC_PS_2_1"],
"PressureMeasurement": [
"Test_TC_PRS_1_1",
Expand Down Expand Up @@ -367,6 +368,7 @@
"OTASoftwareUpdate",
"OccupancySensing",
"OnOff",
"OperationalState",
"PowerSource",
"PressureMeasurement",
"PumpConfigurationControl",
Expand Down
Loading

0 comments on commit 6f49f93

Please sign in to comment.