Skip to content

Commit

Permalink
Remove System::Object (#12051)
Browse files Browse the repository at this point in the history
#### Problem

All uses of `System::Object` pools have now converted to
use `chip::ObjectPool` from `lib/support/Pool.h`.

#### Change overview

- Remove `System::Object`
- Fix some formerly transitive includes.

#### Testing

CI for build. No change to active code.
  • Loading branch information
kpschoedel authored and pull[bot] committed Feb 4, 2022
1 parent 495b5cf commit 66d65a4
Show file tree
Hide file tree
Showing 11 changed files with 8 additions and 1,025 deletions.
1 change: 1 addition & 0 deletions examples/shell/shell_common/cmd_send.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>

#include <lib/core/CHIPCore.h>
#include <lib/shell/Engine.h>
Expand Down
4 changes: 3 additions & 1 deletion src/inet/tests/TestSetupFaultInjectionPosix.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@
#include <lib/support/CHIPFaultInjection.h>
#include <lib/support/CodeUtils.h>
#include <lib/support/ScopedBuffer.h>
#include <stdio.h>
#include <system/SystemFaultInjection.h>

#include <stdio.h>
#include <unistd.h>

struct RestartCallbackContext
{
int mArgc;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

#include "UserDirectedCommissioning.h"

#include <unistd.h>

namespace chip {
namespace Protocols {
namespace UserDirectedCommissioning {
Expand Down
2 changes: 0 additions & 2 deletions src/system/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@ static_library("system") {
"SystemLayerImpl.h",
"SystemMutex.cpp",
"SystemMutex.h",
"SystemObject.cpp",
"SystemObject.h",
"SystemPacketBuffer.cpp",
"SystemPacketBuffer.h",
"SystemStats.cpp",
Expand Down
1 change: 0 additions & 1 deletion src/system/SystemLayer.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include <system/SystemClock.h>
#include <system/SystemError.h>
#include <system/SystemEvent.h>
#include <system/SystemObject.h>
#include <system/SystemTimer.h>

#if CHIP_SYSTEM_CONFIG_USE_SOCKETS
Expand Down
106 changes: 0 additions & 106 deletions src/system/SystemObject.cpp

This file was deleted.

Loading

0 comments on commit 66d65a4

Please sign in to comment.