Add sub-list test and comment

project-chip · Aug 25, 2023 · 5cc2bfa · 5cc2bfa
1 parent dacf280
commit 5cc2bfa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/python_testing/TC_DeviceBasicComposition.py b/src/python_testing/TC_DeviceBasicComposition.py
@@ -289,6 +289,7 @@ def find_tag_list_problems(roots: list[int], device_types: dict[int, dict[int, s
                 for other in endpoints:
                     if other == endpoint:
                         continue
+                    # The OTHER endpoint is missing a tag list attribute - ignore this here, we'll catch that when we assess this endpoint as the primary
                     if Clusters.Descriptor.Attributes.TagList not in endpoint_dict[other][Clusters.Descriptor]:
                         continue
 

diff --git a/src/python_testing/TestMatterTestingSupport.py b/src/python_testing/TestMatterTestingSupport.py
@@ -527,6 +527,16 @@ def test_tag_list_problems(self):
         problems = find_tag_list_problems(roots, device_types, simple)
         asserts.assert_equal(len(problems), 0, "Unexpected problems found in list")
 
+        # One tag list is a subset of the other - this should pass
+        tag1 = Clusters.Descriptor.Structs.SemanticTagStruct(tag=1)
+        tag2 = Clusters.Descriptor.Structs.SemanticTagStruct(tag=2)
+        tag3 = Clusters.Descriptor.Structs.SemanticTagStruct(tag=3)
+
+        simple[2][Clusters.Descriptor][Clusters.Descriptor.Attributes.TagList] = [tag1, tag2]
+        simple[3][Clusters.Descriptor][Clusters.Descriptor.Attributes.TagList] = [tag1, tag2, tag3]
+        problems = find_tag_list_problems(roots, device_types, simple)
+        asserts.assert_equal(len(problems), 0, "Unexpected problems found in list")
+
 
 if __name__ == "__main__":
     default_matter_test_main()