Skip to content

Commit

Permalink
Move Fan Control Cluster to spec (#30182)
Browse files Browse the repository at this point in the history
* Fan control to spec

* Add to darwin backwards compatibility and zap regen

* Fix Darwin availability annotations.

* minor change to kick CI

* Remove read/write of fan mode sequence, as the spec says it is read only

* zap regen

---------

Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
  • Loading branch information
3 people authored Nov 7, 2023
1 parent a61a58f commit 5c4a9c8
Show file tree
Hide file tree
Showing 27 changed files with 161 additions and 339 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1127,8 +1127,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -1157,7 +1157,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute int8u speedMax = 4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3705,8 +3705,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -3735,7 +3735,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute int8u speedMax = 4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2864,8 +2864,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -2894,7 +2894,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1127,8 +1127,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -1157,7 +1157,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute int8u speedMax = 4;
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_fan_7N2TobIlOX.matter
Original file line number Diff line number Diff line change
Expand Up @@ -1178,8 +1178,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -1208,7 +1208,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute int8u speedMax = 4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1493,8 +1493,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -1523,7 +1523,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute int8u speedMax = 4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1059,8 +1059,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -1089,7 +1089,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter
Original file line number Diff line number Diff line change
Expand Up @@ -1300,8 +1300,8 @@ provisional client cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -1330,7 +1330,7 @@ provisional client cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute optional int8u speedMax = 4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1618,8 +1618,8 @@ provisional server cluster FanControl = 514 {
kOffLowHigh = 1;
kOffLowMedHighAuto = 2;
kOffLowHighAuto = 3;
kOffOnAuto = 4;
kOffOn = 5;
kOffHighAuto = 4;
kOffHigh = 5;
}

enum StepDirectionEnum : enum8 {
Expand Down Expand Up @@ -1648,7 +1648,7 @@ provisional server cluster FanControl = 514 {
}

attribute FanModeEnum fanMode = 0;
attribute FanModeSequenceEnum fanModeSequence = 1;
readonly attribute FanModeSequenceEnum fanModeSequence = 1;
attribute nullable percent percentSetting = 2;
readonly attribute percent percentCurrent = 3;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down
Loading

0 comments on commit 5c4a9c8

Please sign in to comment.