Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nivi Sarkar <[email protected]>
  • Loading branch information
bzbarsky-apple and nivi-apple authored Jun 5, 2024
1 parent 043bd33 commit 5717cf4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/darwin/Framework/CHIP/ServerEndpoint/MTRServerAttribute.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ MTR_AVAILABLE(ios(17.6), macos(14.6), watchos(10.6), tvos(17.6))
* Will fail if the attribute ID is not valid per the Matter specification or
* the attribute value is not a valid data-value.
*
* requiredPrivilege is the privilege required to read the attribute. This
* requiredPrivilege is the privilege required to read the attribute. This
* initializer may fail if the provided attributeID is a global attribute and
* the provided requiredPrivilege value is not correct for that attribute ID.
*/
Expand All @@ -58,7 +58,7 @@ MTR_AVAILABLE(ios(17.6), macos(14.6), watchos(10.6), tvos(17.6))
/**
* Create an attribute description for a FeatureMap attribute with the provided
* value (expected to be an unsigned integer representing the value of the
* bitmap). This will automatically set requiredPrivilege to the right value
* bitmap). This will automatically set requiredPrivilege to the right value
* for FeatureMap.
*/
+ (MTRServerAttribute *)newFeatureMapAttributeWithInitialValue:(NSNumber *)value;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ - (nullable instancetype)initWithAttributeID:(NSNumber *)attributeID value:(NSDi
_writable = writable;
_parentCluster = app::ConcreteClusterPath(kInvalidEndpointId, kInvalidClusterId);

// now store the value and its serialization. This will also check that the
// Now store the value and its serialization. This will also check that the
// value is serializable to TLV.
if ([self setValueInternal:value logIfNotAssociated:NO] == NO) {
return nil;
Expand Down

0 comments on commit 5717cf4

Please sign in to comment.