Skip to content

Commit

Permalink
Rebase and fix conflicts, add some wait time to a test that sometimes…
Browse files Browse the repository at this point in the history
… get delayed in Darwin test and reads the value too soon
  • Loading branch information
jmartinez-silabs committed Jan 14, 2022
1 parent 441cf95 commit 4c4a0ad
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/app/tests/suites/certification/Test_TC_LVL_3_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ tests:
arguments:
values:
- name: "ms"
value: 10
value: 100

- label: "reads CurrentLevel attribute from DUT"
command: "readAttribute"
Expand Down
4 changes: 2 additions & 2 deletions src/app/util/util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -984,14 +984,14 @@ uint8_t emberAfMake8bitEncodedChanPg(uint8_t page, uint8_t channel)
bool emberAfContainsAttribute(chip::EndpointId endpoint, chip::ClusterId clusterId, chip::AttributeId attributeId, bool asServer)
{
uint8_t mask = asServer ? CLUSTER_MASK_SERVER : CLUSTER_MASK_CLIENT;
return (emberAfLocateAttributeMetadata(endpoint, clusterId, attributeId, mask, 0) != nullptr);
return (emberAfLocateAttributeMetadata(endpoint, clusterId, attributeId, mask) != nullptr);
}

bool emberAfIsNonVolatileAttribute(chip::EndpointId endpoint, chip::ClusterId clusterId, chip::AttributeId attributeId,
bool asServer)
{
uint8_t mask = asServer ? CLUSTER_MASK_SERVER : CLUSTER_MASK_CLIENT;
EmberAfAttributeMetadata * metadata = emberAfLocateAttributeMetadata(endpoint, clusterId, attributeId, mask, 0);
EmberAfAttributeMetadata * metadata = emberAfLocateAttributeMetadata(endpoint, clusterId, attributeId, mask);

if (metadata == nullptr)
{
Expand Down
2 changes: 1 addition & 1 deletion src/darwin/Framework/CHIPTests/CHIPClustersTests.m

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion zzz_generated/chip-tool/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4c4a0ad

Please sign in to comment.