address review comments

project-chip · Apr 26, 2023 · 4b2d147 · 4b2d147
1 parent 97a89ad
commit 4b2d147
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/examples/platform/silabs/efr32/rs911x/wfx_rsi_host.c b/examples/platform/silabs/efr32/rs911x/wfx_rsi_host.c
@@ -32,6 +32,7 @@
 
 #include "wfx_host_events.h"
 #include "wfx_rsi.h"
+#include "rsi_error.h"
 
 /* wfxRsi Task will use as its stack */
 StackType_t wfxRsiTaskStack[WFX_RSI_TASK_SZ] = { 0 };
@@ -206,7 +207,7 @@ sl_status_t wfx_connect_to_ap(void)
  ***********************************************************************/
 sl_status_t wfx_power_save()
 {
-    if (wfx_rsi_power_save() != 0)
+    if (wfx_rsi_power_save() != RSI_ERROR_NONE)
     {
         return SL_STATUS_FAIL;
     }

diff --git a/src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp b/src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp
@@ -382,7 +382,7 @@ void ConnectivityManagerImpl::OnStationConnected()
     (void) PlatformMgr().PostEvent(&event);
     // Setting the rs911x in the power save mode
 #if (CHIP_DEVICE_CONFIG_ENABLE_SED && RS911X_WIFI)
-    // TODO : Remove stop advertising after BLEManagerImpl is fixed
+    // TODO: Remove stop advertising after BLEManagerImpl is fixed
 #if RSI_BLE_ENABLE
     chip::DeviceLayer::Internal::BLEManagerImpl().StopAdvertising();
 #endif /* RSI_BLE_ENABLE */

diff --git a/src/platform/silabs/efr32/rs911x/BLEManagerImpl.cpp b/src/platform/silabs/efr32/rs911x/BLEManagerImpl.cpp
@@ -666,7 +666,7 @@ CHIP_ERROR BLEManagerImpl::StopAdvertising(void)
     CHIP_ERROR err = CHIP_NO_ERROR;
     int32_t status = 0;
     // TODO: add the below code in a condition if (mFlags.Has(Flags::kAdvertising))
-    // Since DriveBLEState is not called the device is still advertising advertising
+    // Since DriveBLEState is not called the device is still advertising
     mFlags.Clear(Flags::kAdvertising).Clear(Flags::kRestartAdvertising);
     mFlags.Set(Flags::kFastAdvertisingEnabled, true);
     status = rsi_ble_stop_advertising();

diff --git a/third_party/silabs/efr32_sdk.gni b/third_party/silabs/efr32_sdk.gni
@@ -343,6 +343,7 @@ template("efr32_sdk") {
       if (defined(invoker.chip_enable_wifi) && invoker.chip_enable_wifi) {
         defines += [
           # Used for wifi devices to get packet details
+          # TODO: Remove this flag, once the communication is fixed
           "WIFI_DEBUG_ENABLED=1",
         ]
       }