Skip to content

Commit

Permalink
Remove Obsolete TODOs in the AddTrustedRootCertificate and AddNOC Com…
Browse files Browse the repository at this point in the history
…mands.
  • Loading branch information
emargolis committed Jul 21, 2022
1 parent 94f8974 commit 4660837
Showing 1 changed file with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,6 @@ bool emberAfOperationalCredentialsClusterAddNOCCallback(app::CommandHandler * co
// Flush acks before really slow work
commandObj->FlushAcksRightAwayOnSlowCommand();

// TODO: Add support for calling AddNOC without a prior AddTrustedRootCertificate if
// the root properly matches an existing one.

// We can't possibly have a matching root based on the fact that we don't have
// a shared root store. Therefore we would later fail path validation due to
// missing root. Let's early-bail with InvalidNOC.
Expand Down Expand Up @@ -1197,8 +1194,6 @@ bool emberAfOperationalCredentialsClusterAddTrustedRootCertificateCallback(
// Flush acks before really slow work
commandObj->FlushAcksRightAwayOnSlowCommand();

// TODO(#17208): Handle checking for byte-to-byte match with existing fabrics before allowing the add

err = ValidateChipRCAC(rootCertificate);
VerifyOrExit(err == CHIP_NO_ERROR, finalStatus = Status::InvalidCommand);

Expand Down

0 comments on commit 4660837

Please sign in to comment.