Skip to content

Commit

Permalink
[Boolean State Configuration] Fixes to test steps found during TE2 pr…
Browse files Browse the repository at this point in the history
…ep (#31641)

* BOOLCFG test fixes

* Fixed wrong bit used for command in 5.1 step 9b
  • Loading branch information
ReneJosefsen authored Jan 25, 2024
1 parent e5f5d67 commit 39bcd5d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/python_testing/TC_BOOLCFG_4_4.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ async def test_TC_BOOLCFG_4_4(self):
logging.info("Test step skipped")

self.step("5b")
if is_vis_feature_supported:
if is_aud_feature_supported:
enabledAlarms |= Clusters.BooleanStateConfiguration.Bitmaps.AlarmModeBitmap.kAudible
else:
logging.info("Test step skipped")
Expand Down
4 changes: 2 additions & 2 deletions src/python_testing/TC_BOOLCFG_5_1.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ async def test_TC_BOOLCFG_5_1(self):
logging.info("Test step skipped")

self.step("5b")
if is_vis_feature_supported:
if is_aud_feature_supported:
enabledAlarms |= Clusters.BooleanStateConfiguration.Bitmaps.AlarmModeBitmap.kAudible
else:
logging.info("Test step skipped")
Expand Down Expand Up @@ -160,7 +160,7 @@ async def test_TC_BOOLCFG_5_1(self):
self.step("9b")
if not is_aud_feature_supported:
try:
await self.send_single_cmd(cmd=Clusters.Objects.BooleanStateConfiguration.Commands.SuppressAlarm(alarmsToSuppress=Clusters.BooleanStateConfiguration.Bitmaps.AlarmModeBitmap.kVisual), endpoint=endpoint)
await self.send_single_cmd(cmd=Clusters.Objects.BooleanStateConfiguration.Commands.SuppressAlarm(alarmsToSuppress=Clusters.BooleanStateConfiguration.Bitmaps.AlarmModeBitmap.kAudible), endpoint=endpoint)
asserts.fail("Received Success response when an CONSTRAINT_ERROR was expected")
except InteractionModelError as e:
asserts.assert_equal(e.status, Status.ConstraintError, "Unexpected error returned")
Expand Down
2 changes: 1 addition & 1 deletion src/python_testing/TC_BOOLCFG_5_2.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ async def test_TC_BOOLCFG_5_2(self):
logging.info("Test step skipped")

self.step("5b")
if is_vis_feature_supported:
if is_aud_feature_supported:
enabledAlarms |= Clusters.BooleanStateConfiguration.Bitmaps.AlarmModeBitmap.kAudible
else:
logging.info("Test step skipped")
Expand Down

0 comments on commit 39bcd5d

Please sign in to comment.